Skip to content

Improvements to proof-loading speed on reruns #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 24, 2024
Merged

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Jan 22, 2024

These are pulled out of the CSE PR: #284. This includes:

  • Telling our tools to ignore various generated files in the Foundry test directory (ignore Python files from Foundry in our formatting, and ignore generated files in our gitignore).
  • Avoid loading lots of versions of a given proof when only one is called for. This is done by changing Foundry.proofs_with_test(...) -> list[Proof] to Foundry.proof_ids_with_test(...) -> list[str], and allowing the call-site to decide whether to load the proof or not. This significantly reduces startup time when there are several versions of a given proof present.
  • Renames internal function run_prover to prefixed version _run_prover to avoid confusion with run_prover imported from KEVM.
  • Avoids setting up kore-server for already passed proofs, which speeds up the re-run time on a batch of proofs where some proofs have passed and others haven't.
  • Removes a little dead-code.

@ehildenb ehildenb changed the title Cleanups related to implementing CSE for proofs Improvements to proof-loading speed on reruns Jan 23, 2024
…}.is_{test,testfail,setup}"

This reverts commit c723be5.
@ehildenb ehildenb self-assigned this Jan 23, 2024
@ehildenb ehildenb marked this pull request as ready for review January 23, 2024 20:29
@rv-jenkins rv-jenkins merged commit 7c6fac7 into master Jan 24, 2024
@rv-jenkins rv-jenkins deleted the repo-cleanup branch January 24, 2024 07:02
@ehildenb ehildenb added cse and removed cse labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants