-
Notifications
You must be signed in to change notification settings - Fork 12
Improvements to proof-loading speed on reruns #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f75efa9
to
78472d5
Compare
…ed logic for matching test ids
…st,testfail,setup}
…d and already passed
78472d5
to
5b03bb8
Compare
…}.is_{test,testfail,setup}" This reverts commit c723be5.
nwatson22
suggested changes
Jan 23, 2024
nwatson22
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are pulled out of the CSE PR: #284. This includes:
Foundry.proofs_with_test(...) -> list[Proof]
toFoundry.proof_ids_with_test(...) -> list[str]
, and allowing the call-site to decide whether to load the proof or not. This significantly reduces startup time when there are several versions of a given proof present.run_prover
to prefixed version_run_prover
to avoid confusion withrun_prover
imported from KEVM.kore-server
for already passed proofs, which speeds up the re-run time on a batch of proofs where some proofs have passed and others haven't.