-
Notifications
You must be signed in to change notification settings - Fork 12
Refactor production of initial terms, factor out method identification #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3201ce
to
c9b4ef3
Compare
…st,testfail,setup}
… in KEVM invariant
…on ORIGIN_CELL and CALLER_CELL
37c5272
to
e436e21
Compare
anvacaru
reviewed
Jan 31, 2024
anvacaru
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments that should be addressed.
anvacaru
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! You might need to update the expected output again after 6d470cb .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is pulled out of: #284.
This brings us closer to producing specifications that are usable for CSE when running individual functions directly. In particular:
{Method,Constructor}.{is_test,is_testfail}
are added for binning Solidity methods by their type.test
/testFail
/setUp
, the state is made more specific with it needs to be (behind guards about the type of function it is).ORIGIN_ID
andCALLER_ID
are made to beInt
.OUTPUT_CELL
is made to start as the empty buffer.[OUTPUT_CELL, CALLSTACK_CELL, CALLDEPTH_CELL, ID_CELL, LOG_CELL, ACCESSEDACCOUNTS_CELL, ACCESSEDSTORAGE_CELL, INTERIMSTATES_CELL, STATIC_CELL, ACCOUNTS_CELL]
are left fully symbolic for normal function calls, only filled in forsetUp
andtest
methods.setUp
for producing initial states in the test methods.pytest-timeout
module for timing out individual tests.