This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Attach logs to NDBranch, small refactors #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2024
nwatson22
approved these changes
Jan 22, 2024
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
These are small changes that were made for setting up CSE on Kontrol. In particular: - `NDBranch` are setup to display their rule applications. A helper is factored out for doing this for both edges and ndbranches. - An function-internal variable is prefixed with `_` to avoid shadowing confusing with outer variable. The rule labels attached to `NDBranch` are not populated yet, due to https://github.com/runtimeverification/hs-backend-booster/issues/472, but once that bug is fixed then this will become more useful. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
These are small changes that were made for setting up CSE on Kontrol. In particular: - `NDBranch` are setup to display their rule applications. A helper is factored out for doing this for both edges and ndbranches. - An function-internal variable is prefixed with `_` to avoid shadowing confusing with outer variable. The rule labels attached to `NDBranch` are not populated yet, due to https://github.com/runtimeverification/hs-backend-booster/issues/472, but once that bug is fixed then this will become more useful. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
These are small changes that were made for setting up CSE on Kontrol. In particular: - `NDBranch` are setup to display their rule applications. A helper is factored out for doing this for both edges and ndbranches. - An function-internal variable is prefixed with `_` to avoid shadowing confusing with outer variable. The rule labels attached to `NDBranch` are not populated yet, due to https://github.com/runtimeverification/hs-backend-booster/issues/472, but once that bug is fixed then this will become more useful. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
These are small changes that were made for setting up CSE on Kontrol. In particular: - `NDBranch` are setup to display their rule applications. A helper is factored out for doing this for both edges and ndbranches. - An function-internal variable is prefixed with `_` to avoid shadowing confusing with outer variable. The rule labels attached to `NDBranch` are not populated yet, due to https://github.com/runtimeverification/hs-backend-booster/issues/472, but once that bug is fixed then this will become more useful. --------- Co-authored-by: devops <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are small changes that were made for setting up CSE on Kontrol. In particular:
NDBranchare setup to display their rule applications. A helper is factored out for doing this for both edges and ndbranches._to avoid shadowing confusing with outer variable.The rule labels attached to
NDBranchare not populated yet, due to runtimeverification/haskell-backend#3792, but once that bug is fixed then this will become more useful.