Alloc remapping #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkcumming
commented
Jun 26, 2024
Comment on lines
+51
to
+72
| fn get_index_and_populate_allocs(scc: &mut SerializeCycleCheck, alloc_id: &AllocId) -> usize { | ||
| let galloc = &GlobalAlloc::from(*alloc_id); | ||
| if !scc.seen_allocs.contains(alloc_id) { | ||
| scc.seen_allocs.insert(*alloc_id); | ||
| scc.gallocs_ordered.push(galloc.clone()); | ||
| match galloc { | ||
| GlobalAlloc::Memory(allocation) => { | ||
| (&allocation.provenance.ptrs) | ||
| .into_iter() | ||
| .for_each(|(_, prov)| { get_index_and_populate_allocs(scc, &prov.0); }) | ||
| }, | ||
| _ => {}, | ||
| } | ||
| scc.seen_allocs.len() - 1 | ||
| } else { | ||
| (&scc.gallocs_ordered) | ||
| .into_iter() | ||
| .position(|needle| galloc == needle) | ||
| .unwrap() | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Maybe not the best way to handle things, I feel like there is a lot of cloning especially since the whole vector gets cloned in global_allocs function. What do you think @sskeirik?
There was a problem hiding this comment.
For now, let's not worry about this. We can always fix it in a later version.
sskeirik
approved these changes
Jun 26, 2024
Comment on lines
+51
to
+72
| fn get_index_and_populate_allocs(scc: &mut SerializeCycleCheck, alloc_id: &AllocId) -> usize { | ||
| let galloc = &GlobalAlloc::from(*alloc_id); | ||
| if !scc.seen_allocs.contains(alloc_id) { | ||
| scc.seen_allocs.insert(*alloc_id); | ||
| scc.gallocs_ordered.push(galloc.clone()); | ||
| match galloc { | ||
| GlobalAlloc::Memory(allocation) => { | ||
| (&allocation.provenance.ptrs) | ||
| .into_iter() | ||
| .for_each(|(_, prov)| { get_index_and_populate_allocs(scc, &prov.0); }) | ||
| }, | ||
| _ => {}, | ||
| } | ||
| scc.seen_allocs.len() - 1 | ||
| } else { | ||
| (&scc.gallocs_ordered) | ||
| .into_iter() | ||
| .position(|needle| galloc == needle) | ||
| .unwrap() | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
For now, let's not worry about this. We can always fix it in a later version.
sskeirik
pushed a commit
that referenced
this pull request
Jul 23, 2024
Remove `build_sysroot` folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interning of
AllocIdin serialisation of SMIR, and then separate serialisation ofGlobalAllocmapping to interned values.