conformance test 010 and 009

[Mirko-von-Leipzig]

Note that this includes the missing test messages for case 009.

[niklaslong]

Looks great with a few comments, the main thing being the message kind change.

[niklaslong]

Somewhat expected as the node isn't seeded with any data?

[Mirko-von-Leipzig]

Its.. inconsistent. I did initially seed it with blocks, and then GetBlocks, and GetData(block) work as expected.

Then one has GetData(tx) which actually returns NotFound despite not having data.

I would actually hope that all of these queries should result in an {empty} style response, or NotFound for the GetData.

Essentially I think the node never sends an empty response except for GetData(tx) - because the bitcoin protocol lists it as an example:

notfound is a response to a getdata, sent if any requested data items could not be relayed, for example, because the requested transaction was not in the memory pool or relay set. 

In the end I opted to not seed anything until we can decide what is expected and correct. Happy to add the seeding back.

[niklaslong]

Might be good to have both cases? This would also serve as documentation for the current behaviour in each case and make it easier for ECC/ZF to evaluate what the spec should be.

[Mirko-von-Leipzig]

I'll split up the test case into seeded and unseeded

[Mirko-von-Leipzig]

I've changed to using a macro for the enum asserts. Let me know what you think.

[niklaslong]

Looking good other than a few small things, love the macro 🎉