Redo the scheme's no-std interface#119
Merged
nyonson merged 1 commit intorust-bitcoin:mainfrom Jun 24, 2025
Merged
Conversation
nyonson
changed the title
Collaborator
|
Name changes make sense. From the point of view of the caller it seems nice to not have to worry about the allocations if possible, but if these are going to be wrapped by |
nyonson
force-pushed
the
break-packet-handler
branch
2 times, most recently
from
dd3706c to
37150ed
Compare
Major changes! But confined to the lower level no-std interface, the higher level Async I/O one remains unchanged. There are two big changes which then trickle around the whole library. 1. Cosmetic, but re-name the no-std interface to not include `Reader` and `Writer` suffixes for clarity. These structures are purposely not implementing the standard Read/Write IO traits, so shouldn't follow that naming convention. Those helper wrappers live over in the IO module. 2. Dropped the middle-ground `alloc` feature flag. This change makes the core library just no-std and the I/O module full on std. The inbound and outbound ciphers drop their "alloc" wrapper methods and instead expose helper methods to calculate appropriate buffer lengths, `OutboundCipher::encryption_buffer_len()` and `InboundCipher::decryption_buffer_len()`. These are used by the higher i level IO wrappers.
nyonson
force-pushed
the
break-packet-handler
branch
from
37150ed to
d1327fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes! But confined to the lower level no-std interface, the higher level Async I/O one remains unchanged.
There are two big changes which then trickle around the whole library.
ReaderandWritersuffixes for clarity. These structures are purposely not implementing the standard Read/Write IO traits, so shouldn't follow that naming convention. Those helper wrappers live over in the IO module.PacketHandlerCipherSessionPacketReaderInboundCipherPacketWriterOutboundCipherallocfeature flag. This change makes the core library just no-std and the I/O module full on std. The inbound and outbound ciphers drop their "alloc" wrapper methods and instead expose helper methods to calculate appropriate buffer lengths,OutboundCipher::encryption_buffer_len()andInboundCipher::decryption_buffer_len(). These are used by the higher level IO wrappers.