Remove the use of bip324::serde in traffic#154
Closed
rustaceanrob wants to merge 1 commit intorust-bitcoin:mainfrom
Closed
Remove the use of bip324::serde in traffic#154rustaceanrob wants to merge 1 commit intorust-bitcoin:mainfrom
bip324::serde in traffic#154rustaceanrob wants to merge 1 commit intorust-bitcoin:mainfrom
Conversation
To prepare for removing `bitcoin` as a dependency, we can get a jump by removing the use of `bip324::serde` in the test suite. Understandable if it is too weird to depend on specific commits in the test suite, but throwing it up because it is not a horribly complicated change.
Collaborator
Author
|
Lost on the CI failure. The logic shouldn't have changed at all. I can't get the integration tests to complete locally either. I am stuck at reading the version message from regtest. |
Collaborator
|
I see it locally too, will try to hammer it out today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prepare for removing
bitcoinas a dependency, we can get a jump by removing the use ofbip324::serdein the test suite. Understandable if it is too weird to depend on specific commits in the test suite, but throwing it up because it is not a horribly complicated change.