Fix CI and pin nightly so it shouldn't break again#223
Merged
apoelstra merged 4 commits intorust-bitcoin:masterfrom Aug 2, 2025
Merged
Fix CI and pin nightly so it shouldn't break again#223apoelstra merged 4 commits intorust-bitcoin:masterfrom
apoelstra merged 4 commits intorust-bitcoin:masterfrom
Conversation
Member
Author
|
Something is broken with GA. Will try again in a few hours or days. |
It seems we were using all sorts of versions of these actions throughout our GA files. v2 is deprecated and I think has been removed entirely. Then our fuzz runner is set to ubuntu-20.04 which has also been removed. So update everything to latest. For Rust software there should never be any surprise breakage due to OS changes. But there has been "surprise breakage" many times due to removing old versions.
Member
Author
|
Whew. Ok, got GA to pass. This is ready for review. |
clarkmoody
approved these changes
Aug 2, 2025
Member
clarkmoody
left a comment
clarkmoody
left a comment
There was a problem hiding this comment.
ACK 7a3f493
Tests passing on Rust 1.88
This was referenced Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now I can't test #220 or #221 locally because clippy is failing with the latest nightly.
I can disable the local clippy check but I'd prefer to fix it here.
Should unblock both those PRs.