Open
Conversation
Member
Author
|
BTW as far as I can tell the benches code is not being run (or built/checked/linted) in CI. |
michalkucharczyk
approved these changes
Apr 8, 2024
Collaborator
|
@tcharding Mind rebasing this to ensure current CI still passes? |
Currently we are enabling "rand" using a path dependency in the dev-dependencies because of the benches. This is reducing coverage in CI because "std" is always enabled. Feature gate the bench that requires "rand" and remove the path dependency.
tcharding
force-pushed
the
04-08-bench-rand-dev-dep
branch
from
ec2a2cc to
38538c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we are enabling "rand" using a path dependency in the dev-dependencies because of the benches. This is reducing coverage in CI because "std" is always enabled.
Feature gate the bench that requires "rand" and remove the path dependency.