No more build before test and lock dependencies

[nyonson]

Two little cleanups which I hope make it easier to add some release/debug_assert settings.

First patch drops the builds before running test. I don't think there is any benefit of this, but maybe there was historically or I am just missing something?

Second patch makes sure we are using --locked everywhere so that dependencies are never silently upgraded in CI.

[tcharding]

ACK 47cc9ce

[tcharding]

The new cargo function is giving us some grief @nyonson. It showed up in https://github.com/rust-bitcoin/rust-bitcoin/actions/runs/20219540291/job/58038533409?pr=5391 but you can see the problems by running cargo +nightly clippy in the cargo-rbmt/ directory.

warning: unused variable: `name`
   --> cargo-rbmt/src/test.rs:174:21
    |
174 |                 let name = parts[0];
    |                     ^^^^
175 |                 cargo(sh, "run --example {name}").run()?;
    |                           ---------------------- you might have meant to use string interpolation in this string literal
...
183 |                     cargo(sh, "run --no-default-features --example {name}").run()?;
    |                               -------------------------------------------- you might have meant to use string interpolation in this string literal
...
186 |                     cargo(sh, "run --example {name} --features={features}").run()?;
    |                               -------------------------------------------- you might have meant to use string interpolation in this string literal
    |
    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
help: string interpolation only works in `format!` invocations
    |
175 |                 cargo(sh, format!("run --example {name}")).run()?;
    |                           ++++++++                      +
help: string interpolation only works in `format!` invocations
    |
183 |                     cargo(sh, format!("run --no-default-features --example {name}")).run()?;
    |                               ++++++++                                            +
help: string interpolation only works in `format!` invocations
    |
186 |                     cargo(sh, format!("run --example {name} --features={features}")).run()?;
    |                               ++++++++                                            +
help: if this is intentional, prefix it with an underscore

[nyonson]

The new cargo function is giving us some grief @nyonson. It showed up in https://github.com/rust-bitcoin/rust-bitcoin/actions/runs/20219540291/job/58038533409?pr=5391 but you can see the problems by running cargo +nightly clippy in the cargo-rbmt/ directory.

Ah dang, my bad. I have been testing changes to this by just installing it locally which clearly isn't good enough now. Let me take a pass at cleaning things up.

[tcharding]

Cheers, legend.

[apoelstra]

In 07d9757:

Why is the build redundant? It builds the crate without cfg=test, which cargo test does not.

[apoelstra]

For the record: second commit was reverted in #40

[nyonson]

In 07d9757:

Why is the build redundant? It builds the crate without cfg=test, which cargo test does not.

Oh, I totally missed this, my bad. Is it possible to write code that some how only works with a test dependency or something?

I'll add back the separate build step.

[apoelstra]

Is it possible to write code that some how only works with a test dependency or something?

Yes, by gating some critical part of the code on #[cfg(test)].

[tcharding]

Oh, I totally missed this, my bad.

My mistake too, I reviewed.