Skip to content

cookbook: Upgrade to latest bitcoin 0.32.0 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2024

Conversation

tcharding
Copy link
Member

Upgrade the cookbook to use the latest release of rust-bitcoin.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK bd4391e

@tcharding
Copy link
Member Author

Are you watching this repo @storopoli? I'll wait a few days before merge in case you wanted to review. Thanks.

@storopoli
Copy link
Contributor

No, I'm not but I will. Give me until tomorrow for a review? Thanks for the tagging.

@tcharding
Copy link
Member Author

No rush man, take your time.

@storopoli
Copy link
Contributor

storopoli commented May 1, 2024

I was going through the examples yesterday (wasn't aware of this PR) and I've seen that there's an uncommented line in

```rust
# use std::str::FromStr;
#
# use bitcoin::hashes::Hash;
# use bitcoin::key::{Keypair, TapTweak, TweakedKeypair, UntweakedPublicKey};
# use bitcoin::locktime::absolute;
# use bitcoin::secp256k1::{rand, Message, Secp256k1, SecretKey, Signing, Verification};
# use bitcoin::sighash::{Prevouts, SighashCache, TapSighashType};
# use bitcoin::{
# transaction, Address, Amount, Network, OutPoint, ScriptBuf, Sequence, Transaction, TxIn, TxOut,
Txid, Witness,
# };

see the Txid, Witness,.

Do we fix it in this PR or a different one?

EDIT: Done in #27.

Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bd4391e

Upgrade the cookbook to use the latest release of `rust-bitcoin`.
@tcharding tcharding force-pushed the 04-30-upgrade-bitcoin branch from bd4391e to 54b68a5 Compare May 1, 2024 21:01
@tcharding
Copy link
Member Author

Oh process fail, I can't ack this after the force push so can't merge it - my bad. Re-ack please @apoelstra or @storopoli, then i'll merge.

I rebased to pick up #27, I should not have done that, I'm used to Andrew doing the merging.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 54b68a5

@tcharding tcharding merged commit 536871e into rust-bitcoin:master May 1, 2024
1 check passed
@storopoli
Copy link
Contributor

ACK 54b68a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants