-
Notifications
You must be signed in to change notification settings - Fork 7
cookbook: Upgrade to latest bitcoin 0.32.0 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK bd4391e
Are you watching this repo @storopoli? I'll wait a few days before merge in case you wanted to review. Thanks. |
No, I'm not but I will. Give me until tomorrow for a review? Thanks for the tagging. |
No rush man, take your time. |
I was going through the examples yesterday (wasn't aware of this PR) and I've seen that there's an uncommented line in rust-bitcoin.github.io/cookbook/src/tx_taproot.md Lines 137 to 148 in bd4391e
see the Do we fix it in this PR or a different one? EDIT: Done in #27. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bd4391e
Upgrade the cookbook to use the latest release of `rust-bitcoin`.
bd4391e
to
54b68a5
Compare
Oh process fail, I can't ack this after the force push so can't merge it - my bad. Re-ack please @apoelstra or @storopoli, then i'll merge. I rebased to pick up #27, I should not have done that, I'm used to Andrew doing the merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 54b68a5
ACK 54b68a5 |
Upgrade the cookbook to use the latest release of
rust-bitcoin
.