Migrate to corepc for bitcoind integration tests#41
Merged
tcharding merged 2 commits intorust-bitcoin:masterfrom Dec 4, 2025
Merged
Migrate to corepc for bitcoind integration tests#41tcharding merged 2 commits intorust-bitcoin:masterfrom
tcharding merged 2 commits intorust-bitcoin:masterfrom
Conversation
nyonson
force-pushed
the
corepc-migration
branch
4 times, most recently
from
0da2cb8 to
34763ab
Compare
nyonson
force-pushed
the
corepc-migration
branch
from
34763ab to
f8da0a4
Compare
tcharding
approved these changes
Dec 4, 2025
Member
|
FWIW we can just use this and get [dependencies]
anyhow = "1"
bitcoind = { package = "corepc-node", version = "0.10.1", features = ["download"] }
psbt-v2 = { path = "..", features = ["std", "miniscript"] } |
tcharding
added a commit
to rust-bitcoin/rust-bitcoin-maintainer-tools
that referenced
this pull request
Dec 4, 2025
2d63432 cargo-rbmt: add integration command for corepc conventions (Nick Johnson) Pull request description: This codifies corepc integration testing which I am working on over in [rust-psbt](rust-bitcoin/rust-psbt#41), which is based on the structure in rust-miniscript. ACKs for top commit: tcharding: ACK 2d63432 Tree-SHA512: 0ee5d3a4036d8938cfceb81e85763cc14e05aae691f75a6dda113a88484e32ebf12d336cce78178584fc73e5450d6adebe2e12a78d5a660fc0cf67c41d92271a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new CI job to run the integration tests, based it on rust-miniscript.
Closes #29