Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nightly-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nightly-2025-01-21
nightly-2025-09-26
4 changes: 2 additions & 2 deletions rbmt.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ examples = [

# Features to test with the conventional `std` feature enabled.
# Tests each feature alone with std, all pairs, and all together.
features_with_std = ["rand", "serde", "base64", "miniscript"]
features_with_std = ["rand", "serde", "base64", "miniscript", "silent-payments"]

# Features to test without the `std` feature.
# Tests each feature alone, all pairs, and all together.
# Note: rand is a little weird until we can upgrade secp256k1 to v0.30.0
# Note: miniscript is not included here as it has its own no-std handling
features_without_std = ["serde", "base64"]
features_without_std = ["serde", "base64", "silent-payments"]
5 changes: 5 additions & 0 deletions src/v0/bitcoin/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ impl Psbt {
/// An alias for [`extract_tx_fee_rate_limit`].
///
/// [`extract_tx_fee_rate_limit`]: Psbt::extract_tx_fee_rate_limit
#[allow(clippy::result_large_err)]
pub fn extract_tx(self) -> Result<Transaction, ExtractTxError> {
self.internal_extract_tx_with_fee_rate_limit(Self::DEFAULT_MAX_FEE_RATE)
}
Expand All @@ -145,6 +146,7 @@ impl Psbt {
/// [`ExtractTxError`] variants will contain either the [`Psbt`] itself or the [`Transaction`]
/// that was extracted. These can be extracted from the Errors in order to recover.
/// See the error documentation for info on the variants. In general, it covers large fees.
#[allow(clippy::result_large_err)]
pub fn extract_tx_fee_rate_limit(self) -> Result<Transaction, ExtractTxError> {
self.internal_extract_tx_with_fee_rate_limit(Self::DEFAULT_MAX_FEE_RATE)
}
Expand All @@ -156,6 +158,7 @@ impl Psbt {
/// See [`extract_tx`].
///
/// [`extract_tx`]: Psbt::extract_tx
#[allow(clippy::result_large_err)]
pub fn extract_tx_with_fee_rate_limit(
self,
max_fee_rate: FeeRate,
Expand Down Expand Up @@ -183,6 +186,7 @@ impl Psbt {
}

#[inline]
#[allow(clippy::result_large_err)]
fn internal_extract_tx_with_fee_rate_limit(
self,
max_fee_rate: FeeRate,
Expand Down Expand Up @@ -1038,6 +1042,7 @@ impl From<sighash::TaprootError> for SignError {
/// This error is returned when extracting a [`Transaction`] from a [`Psbt`].
#[derive(Debug, Clone, PartialEq, Eq)]
#[non_exhaustive]
#[allow(clippy::result_large_err)]
pub enum ExtractTxError {
/// The [`FeeRate`] is too high
AbsurdFeeRate {
Expand Down
2 changes: 2 additions & 0 deletions src/v2/extract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ impl Extractor {
/// Perform [`Self::extract_tx_fee_rate_limit`] without the fee rate check.
///
/// This can result in a transaction with absurdly high fees. Use with caution.
#[allow(clippy::result_large_err)]
pub fn extract_tx_unchecked_fee_rate(&self) -> Result<Transaction, ExtractTxError> {
self.internal_extract_tx()
}
Expand Down Expand Up @@ -105,6 +106,7 @@ impl Extractor {
///
/// Uses `miniscript` to do interpreter checks.
#[inline]
#[allow(clippy::result_large_err)]
fn internal_extract_tx(&self) -> Result<Transaction, ExtractTxError> {
if !self.0.is_finalized() {
return Err(ExtractTxError::Unfinalized);
Expand Down