musig: Add warning to SecretNonce::dangerous_into_bytes about encoding instability
#805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing instability libsecp256k1 states that the byte format `SecretNonce::dangerous_into_bytes` returns is not guaranteed to be stable, and therefore rust-secp256k1 users must be careful to only pass the result of `dangerous_into_bytes` to a compatible `dangerous_from_bytes`, according to version and platform. The simplest and most conservative strategy is to only consider same-versioned and same-platform bytes as compatible. In practice, the format is unlikely to change much if at all between most versions, so more permissive strategies can be employed with research and great care by the user.
|
I think this text is good. |
tcharding
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #804 by documenting the potential issues. I think it's an ok-ish first pass, but I'm totally open to rewording it if anyone is inclined.