Add anstyle-ratatui #288
Add anstyle-ratatui #288
Conversation
`anstyle-ratatui` depends on `unicode-width =0.2.0` which creates
an incompatibility
```
error: failed to select a version for `unicode-width`.
... required by package `ratatui v0.29.0`
... which satisfies dependency `ratatui = "^0.29.0"` of package `anstyle-ratatui v0.1.0 (/home/orhun/gh/anstyle/crates/anstyle-ratatui)`
versions that meet the requirements `=0.2.0` are: 0.2.0
all possible versions conflict with previously selected packages.
previously selected package `unicode-width v0.2.2`
... which satisfies dependency `unicode-width = "^0.2.2"` of package `anstyle-svg v0.1.12 (/home/orhun/gh/anstyle/crates/anstyle-svg)`
failed to select a version for `unicode-width` which could resolve this conflict
```
| anstyle-lossy = { version = "1.0.0", path = "../anstyle-lossy" } | ||
| html-escape = "0.2.13" | ||
| unicode-width = "0.2.2" | ||
| unicode-width = "0.2" |
There was a problem hiding this comment.
Why does ratatui use a =? Those are generally discouraged by the Cargo team for being harmful to the community
There was a problem hiding this comment.
There was a problem hiding this comment.
From what I gather for ratatui, it was just a superficial test failure and not a major behavior issue? If so, then that imo is appropriate to use your own lockfile to pin but inappropriate to pin for dependents and cause conflicts.
There was a problem hiding this comment.
The issue was more than just failing tests. IIRC the unicode-width versions that were in question were not semver compatible and we didn't want to silently break the behavior for upstream users by updating unicode-width.
(cc @joshka feel free to clarify if I'm misremembering things)
Pull Request Test Coverage Report for Build 19570729873Details
💛 - Coveralls |
|
Previously I did this in #234. Closed and instead we added the conversion to ratatui itself in ratatui/ratatui#1581. This may be good enough. |
|
Yup, I think I will just use that. Kinda embarrassing that I forgot about that anstyle module 🫣 |
4 participants
As discussed in orhun/cargo-tree-tui#1 (comment)