Skip to content

Conversation

@honsunrise
Copy link
Contributor

@honsunrise honsunrise commented Oct 10, 2025

Fix: #172
Fix: If use -I instead of /imsvc, an incorrect include path will be used, leading to errors like:
lld-link: error: undefined symbol: _mm_movemask_epi8

Test: Temp disable the aarch64 static CRT test due to ring must use clang on windows AArch64. Ref: https://github.com/briansmith/ring/blob/main/build.rs#L594

@honsunrise honsunrise changed the title fix: clang-cl libpath problems Draft: fix: clang-cl libpath problems Oct 10, 2025
@honsunrise honsunrise changed the title Draft: fix: clang-cl libpath problems fix: clang-cl libpath problems Oct 10, 2025
@justsmth
Copy link

Thanks for the fix!

One thing that concerns me (more generally) is that this bug survived for a month in the repo and was included in a release, but none of the CI jobs were failing due to it? What is missing from CI test coverage?

@honsunrise
Copy link
Contributor Author

I believe that after adding tests for the "+crt-static", the coverage should be sufficient (when "+crt-static" is not present, the linking process may not have actually required the library path).

@messense messense merged commit 931a8e8 into rust-cross:main Oct 13, 2025
27 checks passed
@honsunrise honsunrise deleted the fix/clang-cl branch November 10, 2025 02:32
@cyqsimon
Copy link

Kind of sucks that this breaks ring when targeting aarch64-pc-windows-msvc. See #147.

TLDR is that ring currently forces clang for aarch64-pc-windows-msvc, which means it misinterprets /imsvc as a path. Admittedly this is a ring problem, and there is ongoing work to fix this (briansmith/ring#2216).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CFLAGS using -L with clang-cl?

4 participants