Skip to content

typo / grammar in first sentence of Static Guarantees section #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tim-seoss opened this issue Mar 30, 2019 · 2 comments · Fixed by rust-lang/rust#59754
Closed

typo / grammar in first sentence of Static Guarantees section #182

tim-seoss opened this issue Mar 30, 2019 · 2 comments · Fixed by rust-lang/rust#59754

Comments

@tim-seoss
Copy link
Contributor

I think this would probably be considered incorrect grammar in most dialects of English:

"It's Rust's type system what prevents data races at compile time (see Send and Sync traits)."

I'd suggest:

"Rust's type system prevents data races at compile time (see Send and Sync traits)."

or maybe

"It's Rust's type system that prevents data races at compile time (see Send and Sync traits)."

Otherwise can't fault the book yet, keep up the good work!
@adamgreig
Copy link
Member

Thanks for catching this! Would you mind opening a PR to fix this and any other issues you spot?

@tim-seoss tim-seoss mentioned this issue Apr 4, 2019
Merged
bors bot added a commit that referenced this issue Apr 4, 2019
@bors @tim-seoss
Merge #183
7989c72 
183: fix #182 r=jamesmunns a=tim-seoss

PR for #182

Co-authored-by: Tim Small <[email protected]>
@tim-seoss
Copy link
Contributor Author

Fixed with PR #183

@ehuss ehuss mentioned this issue Apr 6, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Apr 6, 2019
@Centril
Rollup merge of rust-lang#59754 - ehuss:update-books, r=frewsxcv
8a69953 
Update books

## nomicon

1 commits in f1ff93b66844493a7b03101c7df66ac958c62418..c02e0e7754a76886e55b976a3a4fac20100cd35d
2019-02-26 13:37:28 -0500 to 2019-03-25 16:52:56 -0400
- dropck: The drop order is now defined (rust-lang/nomicon#113)

## reference

3 commits in 27ad493..98f90ff
2019-03-26 02:06:15 +0100 to 2019-04-06 09:29:08 -0700
- Document repr packed(N). (rust-lang/reference#553)
- Fix broken link in glossary. (rust-lang/reference#558)
- Typo fixes (rust-lang/reference#556)

## embedded-book

2 commits in 07fd3880ea0874d82b1d9ed30ad3427ec98b4e8a..7989c723607ef5b13b57208022259e6c771e11d0
2019-03-27 15:40:52 +0000 to 2019-04-04 12:14:37 +0000
- fix rust-embedded/book#182  (rust-embedded/book#183)
- Add openocd to list of installable packages  (rust-embedded/book#179)
Centril added a commit to Centril/rust that referenced this issue Apr 6, 2019
@Centril
Rollup merge of rust-lang#59754 - ehuss:update-books, r=frewsxcv
cd1165d 
Update books

## nomicon

1 commits in f1ff93b66844493a7b03101c7df66ac958c62418..c02e0e7754a76886e55b976a3a4fac20100cd35d
2019-02-26 13:37:28 -0500 to 2019-03-25 16:52:56 -0400
- dropck: The drop order is now defined (rust-lang/nomicon#113)

## reference

3 commits in 27ad493..98f90ff
2019-03-26 02:06:15 +0100 to 2019-04-06 09:29:08 -0700
- Document repr packed(N). (rust-lang/reference#553)
- Fix broken link in glossary. (rust-lang/reference#558)
- Typo fixes (rust-lang/reference#556)

## embedded-book

2 commits in 07fd3880ea0874d82b1d9ed30ad3427ec98b4e8a..7989c723607ef5b13b57208022259e6c771e11d0
2019-03-27 15:40:52 +0000 to 2019-04-04 12:14:37 +0000
- fix rust-embedded/book#182  (rust-embedded/book#183)
- Add openocd to list of installable packages  (rust-embedded/book#179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update books ehuss/rust
2 participants
@adamgreig @tim-seoss