-
Notifications
You must be signed in to change notification settings - Fork 168
thumbv8m.base +inline-asm = "error: invalid operand for instruction" #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
JJJollyjim
added a commit
to JJJollyjim/cortex-m
that referenced
this issue
Sep 20, 2019
First step in resolving rust-embedded#155
JJJollyjim
added a commit
to JJJollyjim/cortex-m
that referenced
this issue
Sep 20, 2019
First step in resolving rust-embedded#155
The crate certainly compiles once I configure out the basepri stuff.
I can certainly vouch that it breaks rtfm :) |
bors bot
added a commit
that referenced
this issue
Oct 29, 2019
167: Deprecate basepri/basepri_max on thumbv8m.base r=korken89 a=JJJollyjim First step in resolving #155 Co-authored-by: Jamie McClymont <[email protected]>
bors bot
added a commit
that referenced
this issue
Oct 29, 2019
168: Test thumbv8m.base on Travis CI r=korken89 a=JJJollyjim This will fail until #155 is resolved Co-authored-by: Jamie McClymont <[email protected]>
I think this can be closed now, reopen if the issue persists |
adamgreig
pushed a commit
that referenced
this issue
Jan 12, 2022
155: ci: test on stable r=therealprof a=japaric now that 1.31 is out Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
STR
Grab the cortex-m-quickstart template (a version that uses cortex-m v0.6.0) and compile this program:
for the
thumbv8m.base-none-eabi
target but make sure that the "inline-asm" feature of cortex-m has been enabled; you get:The BASEPRI register doesn't exist on ARMv8-M devices that don't have the main extension. The
register::{basepri,basepri_max,faultmask}
APIs should not be exposed for thethumbv8m.base-none-eabi
target.As removing an API is a breaking-change (it breaks libraries; the above error only occurs in applications) I would suggest marking the API as deprecated on the
thumbv8m.base-none-eabi
target and removing it in the next minor version.This API should not be removed from the
thumbv8m.main-none-eabi*
targets (note: main, not base) as it is supported on those devices.Metadata
I also noted that the
thumbv8m.base-none-eabi
target is not being tested on Travis and that it doesn't have special handing (cargo:rustc-cfg
) in thebuild.rs
so there are may be more errors similar to this one in the crate.The text was updated successfully, but these errors were encountered: