Skip to content

Remove unnecessary parenthesis #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Conversation

hug-dev
Copy link
Contributor

@hug-dev hug-dev commented Mar 1, 2020

Otherwise Cargo complains!

This should fix the CI for #193 and #189

Otherwise Cargo complains!

Signed-off-by: Hugues de Valon <[email protected]>
@hug-dev hug-dev requested a review from a team as a code owner March 1, 2020 16:42
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Mar 1, 2020
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 1, 2020
198: Remove unnecessary parenthesis r=jonas-schievink a=hug-dev

Otherwise Cargo complains!

This should fix the CI for #193 and #189 

Co-authored-by: Hugues de Valon <[email protected]>
@thejpster
Copy link
Contributor

Uh ... why didn't bors close this PR after the merge?

@jonas-schievink
Copy link
Contributor

It didn't merge, bors shows it as canceled. Weird.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 1, 2020

Build succeeded

@bors bors bot merged commit 947714e into rust-embedded:master Mar 1, 2020
@hug-dev hug-dev deleted the fix-parenthesis branch March 1, 2020 17:26
adamgreig added a commit that referenced this pull request Jan 12, 2022
198: Discard .ARM.exidx, closes #197 r=thejpster a=adamgreig



Co-authored-by: Adam Greig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants