-
Notifications
You must be signed in to change notification settings - Fork 168
Prepare for v0.7.0 #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for v0.7.0 #286
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
NB closes #281 |
Don't think I currently have time to review this. r? @therealprof |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, regarding CI, it seems like we hit rust-lang/rust#39935
Oh, another thing, I thought we would incorporate |
We can merge panic-itm into this repository after releasing 0.7, and then make a new release of panic-itm with updated links and a dependency allowing use with cortex-m 0.7 at the same time. Since the crates still get published separately (at least for now), there's no need to merge it before cortex-m 0.7 is released, as I understand it anyway. |
Are the items in the |
Yep, I missed those off the CHANGELOG updates somehow. Everything in the current master branch will be included. I'll update the changelog, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, went through all the changes and I think it's complete.
bors r+
👎 Rejected by code reviews |
@thalesfragoso Happy? If so could you remove the change request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for holding this, I thought my review would be dismissed by the new changes. Anyways, thanks again!
bors r+
Build succeeded: |
v0.7.0 is released 🎉 |
286: Fix possible overflow of .data region in FLASH r=jonas-schievink a=Guilucand Hi, i found a bug on the size checking of the FLASH region, that in some cases allows it to be larger than it's defined size. This happens because the .data section is placed on a FLASH address (at the end of __erodata) but it's not checked against the FLASH region size. Changing the section as shown solves the issue. Co-authored-by: Guilucand <[email protected]>
I think I got everything in the changelog updates but please point out anything I missed. Anything else missing before we're ready for 0.7.0?
Note that my plan is to now release cortex-m-semihosting 0.3.6 (with support for cortex-m >0.5&&<0.8) and 0.4.2 (cortex-m ^0.7, with our recent breaking changes) after cortex-m 0.7 is out.