Skip to content

Fix no_run typo #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix no_run typo #300

merged 1 commit into from
Jul 27, 2021

Conversation

Sh3Rm4n
Copy link
Contributor

@Sh3Rm4n Sh3Rm4n commented Jul 27, 2021

This typo lead to this example:

https://docs.rs/embedded-hal/1.0.0-alpha.4/embedded_hal/index.html#suggested-implementation

not being highlighted correctly.

@Sh3Rm4n Sh3Rm4n requested a review from a team as a code owner July 27, 2021 10:02
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eldruin (or someone else) soon.

Please see the contribution instructions for more information.

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!
bors r+

@bors bors bot merged commit 18f7a0a into rust-embedded:master Jul 27, 2021
bors bot added a commit that referenced this pull request Aug 3, 2021
305: Fix serial doctest + require passing tests on bors r=therealprof a=eldruin

This escaped CI somehow in #300.
Thanks to `@adamgreig` for his help in figuring this out.
Now passing the tests is also a requirement for bors.

Co-authored-by: Diego Barrios Romero <[email protected]>
bors bot added a commit that referenced this pull request Aug 3, 2021
305: Fix serial doctest + require passing tests on bors r=therealprof a=eldruin

This escaped CI somehow in #300.
Thanks to `@adamgreig` for his help in figuring this out.
Now passing the tests is also a requirement for bors.

Co-authored-by: Diego Barrios Romero <[email protected]>
bors bot added a commit that referenced this pull request Aug 3, 2021
305: Fix serial doctest + require passing tests on bors r=therealprof a=eldruin

This escaped CI somehow in #300.
Thanks to `@adamgreig` for his help in figuring this out.
Now passing the tests is also a requirement for bors.

Co-authored-by: Diego Barrios Romero <[email protected]>
Co-authored-by: Daniel Egger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants