spi: allow impls returning early, add flush. #365
Merged
bors[bot] merged 2 commits intorust-embedded:masterfrom Feb 24, 2022
Merged
spi: allow impls returning early, add flush. #365bors[bot] merged 2 commits intorust-embedded:masterfrom
bors[bot] merged 2 commits intorust-embedded:masterfrom
Conversation
|
r? @therealprof (rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
ryankurte
reviewed
Feb 17, 2022
adamgreig
reviewed
Feb 17, 2022
Dirbaio
force-pushed
the
spi-flush
branch
4 times, most recently
from
9520962 to
a0c1ed2
Compare
Merged
Member
Author
|
New version
|
eldruin
reviewed
Feb 24, 2022
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Other the nitpick below, looks good to me!
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Contributor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #264
Depends on #351
flushmethod to wait for bus to be idle.The alternative is to document that methods MUST wait for bus idle before returning, but that would be bad for performance IMO. Allowing early return means multiple successive writes can "overlap" so that bytes come out back-to-back without gaps, which is great for workloads with tons of small writes, like SPI displays with
embedded-graphics.Drivers using
SpiDevicewon't have to worry about this, it'll Just Work since Device impls must flush before deasserting CS. Drivers using SpiBus will have to care if they coordinate SPI activity with other GPIO activity.