Skip to content

Comments

async/serial: add Write.#442

Merged
bors[bot] merged 1 commit intorust-embedded:masterfrom
embassy-rs:async-serial-write
Mar 14, 2023
Merged

async/serial: add Write.#442
bors[bot] merged 1 commit intorust-embedded:masterfrom
embassy-rs:async-serial-write

Conversation

@Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Mar 7, 2023

Extracted out of #349

This is just Write, mirroring the blocking version. so it should hopefully be uncontroversial.

@Dirbaio Dirbaio requested a review from a team as a code owner March 7, 2023 23:35
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
bors r+

@Dirbaio
Copy link
Member Author

Dirbaio commented Mar 14, 2023

bors r+

seems bors is lazy today?

@bors bors bot merged commit 1533716 into rust-embedded:master Mar 14, 2023
eldruin added a commit to eldruin/embedded-hal that referenced this pull request Mar 15, 2023
eldruin added a commit to eldruin/embedded-hal that referenced this pull request Mar 15, 2023
bors bot added a commit that referenced this pull request Mar 15, 2023
446: Update changelog after #442 r=Dirbaio a=eldruin

This was forgotten in #442 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants