Skip to content

Force use of mdbook 0.2.1 as 0.2.2 is broken for now #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2018
Merged

Force use of mdbook 0.2.1 as 0.2.2 is broken for now #31

merged 4 commits into from
Nov 10, 2018

Conversation

adamgreig
Copy link
Member

@adamgreig adamgreig requested a review from a team as a code owner November 10, 2018 00:24
This was referenced Nov 10, 2018
Closed
Merged
jamesmunns
jamesmunns previously approved these changes Nov 10, 2018
View reviewed changes
Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors r+

bors bot added a commit that referenced this pull request Nov 10, 2018
@bors @adamgreig
Merge #31
4a4f90c 
31: Force use of mdbook 0.2.1 as 0.2.2 is broken for now r=jamesmunns a=adamgreig

See rust-embedded/book#58

Co-authored-by: Adam Greig <[email protected]>
@jamesmunns jamesmunns mentioned this pull request Nov 10, 2018
Closed
@bors
Copy link
Contributor

bors bot commented Nov 10, 2018

Build failed

@jamesmunns
Copy link
Member

Huh, looks like some missing let _ = ...s ? Not sure why it started failing on this build.

@adamgreig
Copy link
Member Author

I think an updated cortex-m-semihosting might be triggering the warning but I'm not sure that's even what's causing the eventual failure, which is that b7c isn't appearing in release.objdump. I'm investigating...

@adamgreig
Copy link
Member Author

Think I found the error in the CI script, testing...

@adamgreig
Copy link
Member Author

adamgreig commented Nov 10, 2018 •
edited
Loading

The log statics used to be local and are now global...

In this repository, ci/logging/app2/dev.objdump:

00000001 l       .log            00000001 Goodbye
00000000 l       .log            00000001 Hello, world!

If I run arm-none-eabi-objdump -t target/thumbv7m-none-eabi/debug/app | grep '\.log':

00000001 g     O .log   00000001 Goodbye
00000000 g     O .log   00000001 Hello, world!

@adamgreig
Copy link
Member Author

I believe rust-lang/rust#54414 is to blame.

@adamgreig
Copy link
Member Author

Whew. What a pain. Shame we can't have Travis build all the masters on a regular basis to catch this sort of test rot.

@adamgreig
Copy link
Member Author

@jamesmunns re-r?

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Nov 10, 2018
@bors @adamgreig
Merge #31
f03b9f1 
31: Force use of mdbook 0.2.1 as 0.2.2 is broken for now r=therealprof a=adamgreig

See rust-embedded/book#58

Co-authored-by: Adam Greig <[email protected]>
@therealprof
Copy link
Contributor

@adamgreig

Whew. What a pain. Shame we can't have Travis build all the masters on a regular basis to catch this sort of test rot.

Why not? I think most of the repos are already built regularly using a recurring "cron" task.

@bors
Copy link
Contributor

bors bot commented Nov 10, 2018

Build succeeded

@bors bors bot merged commit aff95c5 into master Nov 10, 2018
@bors bors bot deleted the fix-mdbook branch November 10, 2018 12:45
@adamgreig
Copy link
Member Author

Oh, you're quite right. I've set up daily builds for the book repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@jamesmunns jamesmunns jamesmunns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamgreig @jamesmunns @therealprof