Added input pin impl (requires unproven hal trait) #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded |
|
@ryankurte Well, you could submit a PR to close rust-embedded/embedded-hal#41 . ;) |
|
@therealprof I considered that but it would seem impolite to land it before @eldruin's rust-embedded/embedded-hal#97 |
|
@ryankurte As mentioned in the PR you just closed, I do see them as two separate topics. Making this unproven does not preclude making it fallible since this will end up in two different (incompatible) HAL versions anyway. |
|
Would it be possible to release and accept this PR as the embedded hal discussion seems to still need a bit more time? |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 25, 2018
11: Added input pin impl (requires unproven hal trait) r=therealprof a=ryankurte Do we have opinions on the use of `unproven` traits in this library? Co-authored-by: Ryan Kurte <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we have opinions on the use of
unproventraits in this library?