This repository was archived by the owner on Nov 28, 2023. It is now read-only.
don't declare _start_rust as a "naked" function #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #[naked] attribute means Rust won't emit instructions to push and pop a new stack frame. But the assembly routine which calls _start_rust also doesn't push a new stack frame, so there is no valid stack for this function. We probably need a stack frame though, since it's implemented in Rust and we can't easily ensure that Rust won't try to allocate any local variables. See rust-embedded#5.
|
Haven't really tested this yet. When I get home later and have the Hifive to hand, I will check that this fixes the problem for real (namely that we don't trap with an access fault even when _start_rust is calling core::ptr::null like we had before). |
|
Awesome! |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #[naked] attribute means Rust won't emit instructions to push and
pop a new stack frame. But the assembly routine which calls _start_rust
also doesn't push a new stack frame, so there is no valid stack for this
function.
We probably need a stack frame though, since it's implemented in Rust
and we can't easily ensure that Rust won't try to allocate any local
variables. See #5.