Add more CSRs #31
Merged
Add more CSRs #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Looks good to me, checked the register numbers and permissions against RV Privileged Architecture spec v1.10. I've also tested the build.
This does make riscv.o noticeably larger (the rv64 one goes from 7k to 67k), which might be a problem for small-memory platforms, or does the one-function-per-section cause only the used functions to be linked in in the final binary?
I've checked and this is indeed the case ! Only what is actually used makes it into the binary. bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 23, 2019
31: Add more CSRs r=laanwj a=Disasm Co-authored-by: Vadim Kaushan <[email protected]>
Build succeeded |
|
Yep, this is quite common pattern for saving space. In two Rust releases we will have even more beautiful solution with ThinLTO. |
romancardenas
pushed a commit
that referenced
this pull request
Nov 17, 2023
31: New linker script and multi-core support r=laanwj a=Disasm * Linker script was reworked. Now it uses region aliases to relocate sections. This approach makes it possible to build firmware for both FLASH+RAM and RAM-only targets. Memory definitions now supposed to be present in their corresponding crates (e.g. RAM definition in PAC crate, FLASH definition in board support crate). * Multi-core support was introduced. Cores are parked with `_mp_hook` function and then awakened in platform-dependent way. * Documentation was updated to reflect new features. * New crate version: 0.6.0 Depends on: #28 Closes: rust-embedded/riscv-rt#26 Co-authored-by: Vadim Kaushan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.