Fix image links in Discovery book #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang/mdBook#789 causes mdbook to generate print.html content with relative URLs that are still relative to the individual HTML files and doesn't correct for the fact that print.html isn't in the same folder. This commit will verify that the relative URLs are correct in all of the HTML output except for discovery/print.html I am assuming that people would like to see the images again in the Discovery book website as they click through the various chapters, even if the printable version is still broken. I have already made the same change to the CI scripts in the discovery repository along with various link fixes. Once this PR is merged, an issue should be created to track the fact that this change should be reverted once mdbook handles relative links correctly in its generaton of print.html
|
bors try |
|
The build for this repository is currently failing after the discovery repository was updated to use relative links: https://travis-ci.org/rust-embedded/bookshelf/builds/448915298 This PR will eliminate that build error. The successful Travis run for this PR can be seen here: https://travis-ci.org/rust-embedded/bookshelf/builds/448784057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The links have already been fixed in the discovery repository and this PR just updates the CI scripts in the bookshelf repo to ignore the print.html link errors so that the bookshelf version will have the fixes too.
More information about the reason for the CI script change follows:
rust-lang/mdBook#789 causes
mdbook to generate print.html content with relative URLs that
are still relative to the individual HTML files and doesn't
correct for the fact that print.html isn't in the same folder.
This commit will verify that the relative URLs are correct in all
of the HTML output except for discovery/print.html I am assuming
that people would like to see the images again in the Discovery
book website as they click through the various chapters, even if
the printable version is still broken.
I have already made the same change to the CI scripts in the
discovery repository along with various link fixes.
Once this PR is merged, an issue should be created to track the
fact that this change should be reverted once mdbook handles
relative links correctly in its generaton of print.html