Skip to content

Remove build.rs and skeptic from build-deps #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Remove build.rs and skeptic from build-deps #47

merged 2 commits into from
Nov 8, 2018

Conversation

ryankurte
Copy link
Contributor

This means the readme file is no longer checked for code errors, however the build tree is vastly simplified.

Related to #41, but it didn't seem worth adding a feature for it.

This means the readme file is no longer checked for code errors, however the build tree is vastly simplified
@nastevens nastevens requested a review from posborne November 8, 2018 15:57
@nastevens
Copy link
Member

Instead of completely removing checking of the README, you can actually perform roughly the same tests with rustdoc. Check it out in the fixedvec project: https://github.com/rust-embedded/fixedvec-rs/blob/master/.travis.yml#L30

@ryankurte
Copy link
Contributor Author

Ahh, that's a neat approach! I moved the example to the rustdocs so it gets tested every time, but can revert that and only test in CI if you'd prefer.

@posborne
Copy link
Member

posborne commented Nov 8, 2018

LGTM; merging (haven't gotten around to setting up bors on this; I can fixup the osx no-op build when I get around to that as well).

@posborne posborne merged commit 8e40032 into rust-embedded:master Nov 8, 2018
@ryankurte ryankurte mentioned this pull request Nov 9, 2018
bors bot added a commit to rust-embedded/linux-embedded-hal that referenced this pull request Dec 20, 2018
14: Bump i2cdev version r=therealprof a=ryankurte

rust-i2cdev has a new minor version that removes a pile of dependencies (and speeds up builds measurably), see: rust-embedded/rust-i2cdev#47

This PR bumps i2cdev to the updated version and adds a missing newline to the end of cargo.toml

Co-authored-by: Ryan Kurte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants