generate defmt::Format for enums #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
defmt
branch
3 times, most recently
from
d35a951 to
d0290bd
Compare
|
should've read the pr message :) |
github-merge-queue
bot
dismissed
therealprof’s stale review
The merge-base changed after approval.
|
rebased |
Emilgardis
reviewed
Nov 23, 2023
| ) | ||
| .arg( | ||
| Arg::new("impl_defmt") | ||
| .long("impl-defmt") |
There was a problem hiding this comment.
this is not consistent with the other flags, unless we also bring in #771
There was a problem hiding this comment.
do you suggest to support both - and _ for all flags, or only for old?
There was a problem hiding this comment.
added alias in last commit
Emilgardis
approved these changes
Nov 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #769