Skip to content

N28: Veloren #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2021
Merged

N28: Veloren #864

merged 4 commits into from
Dec 4, 2021

Conversation

AngelOnFira
Copy link
Member

@AngelOnFira AngelOnFira commented Dec 4, 2021 •
edited
Loading

Part of #852 💯

17cupsofcoffee
17cupsofcoffee approved these changes Dec 4, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments, but looks alright.

17cupsofcoffee
17cupsofcoffee approved these changes Dec 4, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AngelOnFira AngelOnFira merged commit 4c58c34 into rust-gamedev:source Dec 4, 2021
@AngelOnFira AngelOnFira deleted the veloren-dec-2021 branch December 4, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@ozkriff ozkriff Awaiting requested review from ozkriff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AngelOnFira @17cupsofcoffee