Skip to content

Show fixture test location #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Muscraft
Copy link
Member

@Muscraft Muscraft commented Aug 21, 2024

While working on #143, I noticed that fixture test names were missing the "module" (folder) before the name, which usually gets added for normal tests in folders. While this isn't a big deal now, if other test folders get added in the future, it will make it easier to find the failure.

Before:
Screenshot from 2024-08-21 15-31-07

After:
Screenshot from 2024-08-21 16-44-56

@epage
Copy link
Contributor

epage commented Aug 21, 2024

imo showing the source path is more helpful as it helps people more quickly connect with what action they can take and the can copy/paste.

@Muscraft Muscraft force-pushed the show-fixture-test-location branch from 053e387 to 40d2278 Compare August 21, 2024 22:44
@epage epage merged commit 05462f5 into rust-lang:master Aug 21, 2024
13 checks passed
@Muscraft Muscraft deleted the show-fixture-test-location branch August 22, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants