Repository navigation
Conversation
epage
force-pushed
the
footnote
branch
4 times, most recently
from
August 19, 2026 16:40
a7f0733 to
dd371bc
Compare
epage
force-pushed
the
footnote
branch
2 times, most recently
from
August 31, 2026 18:06
91e6e3b to
00e10e6
Compare
Muscraft
reviewed
Oct 16, 2026
Muscraft
left a comment
Muscraft
left a comment
Member
There was a problem hiding this comment.
Could you add a test for when there is a level, id, and footnote marker? It looks like ruff has a few tests cases that show this.
| /// not allowed to be passed to this function. | ||
| /// | ||
| /// </div> | ||
| pub fn footnote(mut self, marker: impl Into<OptionCow<'a>>) -> Self { |
Member
There was a problem hiding this comment.
Why is this footnote and not footnote_marker?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like with any unicode in title's, the caller is responsible for deciding whether a footnote should have unicode.
In support of superscript footnotes, the caller is responsible for whether to wrap footnote markers in
[].Fixes #450