Skip to content

Gimli doesn't support fat libraries on macOS #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcrichton opened this issue May 8, 2020 · 0 comments
Closed

Gimli doesn't support fat libraries on macOS #319

alexcrichton opened this issue May 8, 2020 · 0 comments
Labels
gimli Related to the gimli implementation

Comments

@alexcrichton
Copy link
Member

I noticed in #317 that the tests fail on macOS with the Gimli implementation, meaning that it's currently relying on the dladdr fallback, which is bad!

I tracked this down to a lack of support for fat libraries because the system libraries were failing to parse as a mach-o image (because they weren't!). I've implemented this in 69db3b7 but wanted to track this in any case.

@alexcrichton alexcrichton added the gimli Related to the gimli implementation label May 8, 2020
alexcrichton added a commit that referenced this issue May 10, 2020
This commit updates the object parsing code for macOS to support fat
libraries. This enables gimli to symbolize addresses coming from system
libraries which are currently installed frequently as fat libraries.

Closes #319
alexcrichton added a commit that referenced this issue May 12, 2020
This commit updates the object parsing code for macOS to support fat
libraries. This enables gimli to symbolize addresses coming from system
libraries which are currently installed frequently as fat libraries.

Closes #319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gimli Related to the gimli implementation
Projects
None yet
Development

No branches or pull requests

1 participant