Skip to content

Conversation

@Aaron1011
Copy link
Contributor

No description provided.

@RalfJung
Copy link
Member

This blocks fixing the Miri component, would be good to get it landed ASAP. :)

@alexcrichton
Copy link
Member

If you'd like to ensure that this continues to work over time you can add another thing to test here

@Aaron1011
Copy link
Contributor Author

@alexcrichton: There's some additional work needed to get tests passing under Miri - I plan to open a follow-up PR.

@alexcrichton
Copy link
Member

Oh it's also fine to just test a build, no need to run tests just yet if they don't work.

@Aaron1011
Copy link
Contributor Author

@alexcrichton: I've addressed your comment. If it's okay with you, I'd like to do any CI changes in a follow-up PR, so that we get Miri building again quickly.

@alexcrichton alexcrichton merged commit 893fbb2 into rust-lang:master Oct 11, 2020
@alexcrichton
Copy link
Member

👍

@Aaron1011
Copy link
Contributor Author

@alexcrichton: Do we need to make a new release before bumping the submodule in rustc?

@alexcrichton
Copy link
Member

I believe it's just a submodule update, so no a release isn't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants