Post on language ergonomics initiative #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
nikomatsakis
requested changes
Mar 3, 2017
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
left a few nits, love it
_posts/2017-03-02-lang-ergonomics.md
Outdated
| vital. However: | ||
|
|
||
| - The vast majority of methods borrow `self`, rather than taking it by value. | ||
| - Usually the name of a method makes obvious whether the `self` borrow will be |
Contributor
There was a problem hiding this comment.
Nit: "makes it obvious"
_posts/2017-03-02-lang-ergonomics.md
Outdated
|
|
||
| - The vast majority of methods borrow `self`, rather than taking it by value. | ||
| - Usually the name of a method makes obvious whether the `self` borrow will be | ||
| mutable or not (e.g. `push` versus `len`). |
_posts/2017-03-02-lang-ergonomics.md
Outdated
| - Usually the name of a method makes obvious whether the `self` borrow will be | ||
| mutable or not (e.g. `push` versus `len`). | ||
| - The borrow checker will prevent any incorrect borrowing, though if borrowing | ||
| were too implicit, it could make debugging borrow check errors harder. |
Contributor
There was a problem hiding this comment.
Nit: "borrow-check errors"
| ``` | ||
|
|
||
| But we could easily allow you to write `read_config(path)`, implicitly borrowing | ||
| `path` for `read_config` and then *dropping it* immediately afterwards. That |
Contributor
There was a problem hiding this comment.
I still feel like it might be helpful to say, effectively desugaring into something like:
let config = {
let tmp = path;
read_config(&tmp)
};but perhaps the syntax is too fancy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.