-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix tests including dead_code warnings #10768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
97c8c18
to
c92a15b
Compare
c92a15b
to
03a8490
Compare
rust-lang/rust#97853 was merged. After a nightly including it is released, this PR should be merged. |
Thanks! As mentioned in rust-lang/rust#97853 (comment), when there are diagnostic changes that interfere with cargo's testsuite, the preferred route is to change the test to work with either version of rustc, merge that to master, and then update the submodule. For example, these tests could have been modified to something like I'll go ahead and merge this to fix CI. If these kinds of changes come up in the future, we can further adjust these tests to be more general. Cargo doesn't really care about the specific error/warning text, just that something appears. @bors r+ |
📌 Commit 03a8490 has been approved by |
⌛ Testing commit 03a8490 with merge 9e2062085df7582da853afaa0ffa050710ac60fb... |
💔 Test failed - checks-actions |
I posted #10785 with the fixes to work on both stable and nightly. I'm going to go ahead and close this in favor of that. |
This patch is related to rust-lang/rust#97853. In it, I made some changes to collapse multiple dead code warnings into a single diagnostic. They broke some tests in cargo. After rust-lang/rust#97853 is merged, this PR should be merged.