Skip to content

Document why du function uses mutex #13273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
Jan 10, 2024
Merged

Document why du function uses mutex #13273

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4da5444
chore: document why du function uses mutex
BD103 Jan 9, 2024
529130f
fix: missing word in comment
BD103 Jan 9, 2024
c832cdf
bump: cargo-util to 0.2.10
BD103 Jan 10, 2024
0a6fe23
fix: update lockfile
BD103 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/cargo-util/src/du.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ fn du_inner(path: &Path, patterns: &[&str]) -> Result<u64> {
.git_ignore(false)
.git_exclude(false);
let walker = builder.build_parallel();

// Platforms like PowerPC don't support AtomicU64, so we a Mutex instead.
//
// See:
// - https://github.com/rust-lang/cargo/pull/12981
// - https://github.com/rust-lang/rust/pull/117916#issuecomment-1812635848
let total = Arc::new(Mutex::new(0u64));

// A slot used to indicate there was an error while walking.
//
// It is possible that more than one error happens (such as in different
Expand Down