feat(add/install): check if given crate argument would be valid with inserted @ symbol

[dawedawe]

Suggest to user to use a crate name with an inserted @ before the first invalid package name character

Fixes #15318

[rustbot]

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[weihanglo]

Thanks for the patch!

[weihanglo]

Not a blocker. Would you mind following the atomic commit pattern described here. That is,

As part of your atomic commits, prefer adding tests as their own commit before any functionality changes. The tests should pass in each commit, demonstrating the behavior before your change and how each commit affects behavior.

[dawedawe]

Not a blocker. Would you mind following the atomic commit pattern described here. That is,

As part of your atomic commits, prefer adding tests as their own commit before any functionality changes. The tests should pass in each commit, demonstrating the behavior before your change and how each commit affects behavior.

Oops, sorry. Should have seen that.
Thanks for the review!

[epage]

As a suggestion to clarify what is being asked by the link to the contributor guide, including the tip. The commits could be organized as:

1. A commit that adds all of the tests, with them passing (or separate commits for cargo add and cargo install)
2. A commit that changes cargo install, and updates the tests to pass
3. A commit that changes cargo add, and updates the tests to pass

We're fine with your rewriting your commits during the review process.

[dawedawe]

Okay, I hope the history is acceptable now.

[epage]

Okay, I hope the history is acceptable now.

Thanks, this helps a lot!

[epage]

Thanks!