Skip to content

fix(host-config): host.linker should not apply to non host unit #16641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epage merged 4 commits into from
Feb 16, 2026
Merged

fix(host-config): host.linker should not apply to non host unit #16641

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d60b2c
test(host-config): linker incorrectly apply to normal builds
weihanglo Feb 13, 2026
7a14435
fix(host-config): `host.linker` should not apply to non host unit
weihanglo Feb 13, 2026
13525b7
refactor: rename from target_linkers to linkers
weihanglo Feb 13, 2026
b0f4473
refactor: extract linker/incremental codegen arg into functions
weihanglo Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions tests/testsuite/cross_compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,3 +1299,55 @@ fn always_emit_warnings_as_warnings_when_learning_target_info() {
"#]])
.run();
}

#[cargo_test]
fn host_linker_does_not_apply_to_binary_build() {
// `host.linker` should only apply to build scripts, not to normal binary builds.
let target = rustc_host();
let p = project()
.file(
".cargo/config.toml",
&format!(
r#"
[host]
linker = "nonexistent-host-linker"
[target.{target}]
linker = "nonexistent-target-linker"
"#,
),
)
.file("src/main.rs", "fn main() {}")
.build();

p.cargo("build -Z target-applies-to-host -Z host-config --target")
.arg(&target)
.masquerade_as_nightly_cargo(&["target-applies-to-host", "host-config"])
.with_status(101)
// Need to omit some MSVC-specific diagnostics
// because rustc prints extra stuff when linker was not found.
// https://github.com/rust-lang/rust/blob/7ad4e69ad585d8ff214f7b42d01f1959eda08f40/compiler/rustc_codegen_ssa/src/back/link.rs?plain=1#L971-L975
.with_stderr_data(str![[r#"
[COMPILING] foo v0.0.1 ([ROOT]/foo)
[ERROR] linker `nonexistent-target-linker` not found
|
= [NOTE] [NOT_FOUND]
...
"#]])
.run();

// FIXME: without --target, host.linker incorrectly applies to normal binaries.
Copy link
Copy Markdown
Contributor

@epage epage Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we tracking this fixme? Living in a test adds a second, invisible backlog.

Copy link
Copy Markdown
Member Author

@weihanglo weihanglo Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got removed in the next commit

Copy link
Copy Markdown
Contributor

@epage epage Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was specifically looking to see if that happened and still somehow missed it, thanks

p.cargo("build -Z target-applies-to-host -Z host-config")
.masquerade_as_nightly_cargo(&["target-applies-to-host", "host-config"])
.with_status(101)
// Need to omit some MSVC-specific diagnostics
// because rustc prints extra stuff when linker was not found.
// https://github.com/rust-lang/rust/blob/7ad4e69ad585d8ff214f7b42d01f1959eda08f40/compiler/rustc_codegen_ssa/src/back/link.rs?plain=1#L971-L975
.with_stderr_data(str![[r#"
[COMPILING] foo v0.0.1 ([ROOT]/foo)
[ERROR] linker `nonexistent-host-linker` not found
|
= [NOTE] [NOT_FOUND]
...
"#]])
.run();
}