Send Content-Type header with cargo publish requests by dralley · Pull Request #16832 · rust-lang/cargo

dralley · 2026-04-03T14:13:58Z

What does this PR try to resolve?

Sends an appropriate Content-Type header with cargo publish requests.

Resolves:

How to test and review this PR?

If necessary, find a way to log the request headers / metadata - I tested this against my in-progress registry implementation. Maybe there is logging mode which can skip that step, I'm not sure.

rustbot · 2026-04-03T14:14:04Z

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ehuss, @epage, @weihanglo
@ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
Random selection from ehuss, epage, weihanglo

epage · 2026-04-03T14:16:32Z

Note that our contrib guide asks for Issues to be tagged S-accepted before moving onto PRs.

In addition, this would best be handled with separate PRs because

They are unrelated
They have different compatibility considerations and on or more might need team sign off with an FCP

dralley · 2026-04-03T14:21:25Z

Ok, I can split into two PRs. Apologies.

And I will wait before filing a PR for the other issue.

rustbot · 2026-04-03T14:23:38Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

weihanglo · 2026-04-03T21:35:03Z

#16830 (comment)

Would you mind also updating docs?

I guess we can instead specify content-type in each API respectively

closes rust-lang#16830

Revise how the header documentation is written such that per-endpoint headers are more straightforwards.

Take the body argument as Option<&[u8]

dralley · 2026-04-04T19:35:53Z

@weihanglo The last commit is a separate (but related) issue re: the unyank command, I imagine you might want that split off as a separate PR?

dralley · 2026-04-04T19:39:36Z

    }

-    fn put(&mut self, path: &str, b: &[u8]) -> Result<String> {
+    fn put(&mut self, path: &str, b: Option<&[u8]>) -> Result<String> {


This is how all of the other methods were written, this was otherwise an outlier.

dralley · 2026-04-04T19:45:00Z


    pub fn unyank(&mut self, krate: &str, version: &str) -> Result<()> {
-        let body = self.put(&format!("/crates/{}/{}/unyank", krate, version), &[])?;
+        let body = self.put(&format!("/crates/{}/{}/unyank", krate, version), None)?;


This was setting Content-Type: application/json for a body which was empty (which is not actually valid json)

weihanglo

Thanks for it and also the discussion!

View changes since this review

Cargo submodule update 11 commits in a357df4c26fc14514e66aae2a269456b5545c7db..101549dddbd2b08e806f50154e3aa4cb3374cc21 2026-04-03 16:47:15 +0000 to 2026-04-08 12:51:20 +0000 - Never include use extra-filename in build scripts (rust-lang/cargo#16855) - fix(toml): Force script edition warnings on quiet (rust-lang/cargo#16848) - GitHub fast path uses `http_async` (rust-lang/cargo#16847) - feat(manifest): allow git dependency alongside alternate registry (rust-lang/cargo#16810) - fix(auth): add auth scheme hint to token rejected error for alt registries (rust-lang/cargo#16794) - Warn on invalid jobserver file descriptors (rust-lang/cargo#16843) - docs(unstable): List the minimum required MSRV for 'public' field (rust-lang/cargo#16841) - feat(lints): Emit unused_dependencies lint (rust-lang/cargo#16600) - fix(tree): clarify error message when `-i` is used without a package name (rust-lang/cargo#16818) - fix: Typo in target.<cfg>.linker (rust-lang/cargo#16839) - Send Content-Type header with cargo publish requests (rust-lang/cargo#16832) r? ghost

rustbot assigned weihanglo Apr 3, 2026

rustbot added A-interacts-with-crates.io Area: interaction with registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2026

dralley changed the title ~~Fixes two issues that make writing~~ Fixes two issues that help third party registries Apr 3, 2026

dralley changed the title ~~Fixes two issues that help third party registries~~ Fixes two issues that unnecessarily complicate third party registry implementations Apr 3, 2026

dralley changed the title ~~Fixes two issues that unnecessarily complicate third party registry implementations~~ Send Content-Type header with cargo publish requests Apr 3, 2026

dralley force-pushed the fixes branch from 47e85b4 to 0ac93f9 Compare April 3, 2026 14:22

This comment has been minimized.

Sign in to view

dralley force-pushed the fixes branch from 0ac93f9 to e0197d8 Compare April 3, 2026 14:23

Turbo87 mentioned this pull request Apr 3, 2026

cargo publish does not send Content-Type header #16830

Closed

weihanglo reviewed Apr 3, 2026

View reviewed changes

dralley added 3 commits April 4, 2026 11:13

Send a Content-Type header with cargo publish requests

27cc6bd

closes rust-lang#16830

Update the Web API docs re: headers

cefce46

Revise how the header documentation is written such that per-endpoint headers are more straightforwards.

Make the put() method consistent with the others

c70bba2

Take the body argument as Option<&[u8]

dralley force-pushed the fixes branch from e0197d8 to c70bba2 Compare April 4, 2026 19:35

rustbot added the A-documenting-cargo-itself Area: Cargo's documentation label Apr 4, 2026

dralley commented Apr 4, 2026

View reviewed changes

weihanglo approved these changes Apr 5, 2026

View reviewed changes

weihanglo added this pull request to the merge queue Apr 5, 2026

Merged via the queue into rust-lang:master with commit bc00373 Apr 5, 2026
29 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 5, 2026

dralley deleted the fixes branch April 5, 2026 15:34

weihanglo mentioned this pull request Apr 8, 2026

Update cargo submodule rust-lang/rust#154987

Merged

rustbot added this to the 1.96.0 milestone Apr 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send Content-Type header with cargo publish requests#16832

Send Content-Type header with cargo publish requests#16832
weihanglo merged 3 commits intorust-lang:masterfrom
dralley:fixes

dralley commented Apr 3, 2026 •

edited

Loading

Uh oh!

rustbot commented Apr 3, 2026

Uh oh!

epage commented Apr 3, 2026

Uh oh!

dralley commented Apr 3, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

rustbot commented Apr 3, 2026

Uh oh!

weihanglo Apr 3, 2026

Uh oh!

dralley commented Apr 4, 2026 •

edited

Loading

Uh oh!

dralley Apr 4, 2026

Uh oh!

dralley Apr 4, 2026 •

edited

Loading

Uh oh!

weihanglo left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dralley commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR try to resolve?

How to test and review this PR?

Uh oh!

rustbot commented Apr 3, 2026

Uh oh!

epage commented Apr 3, 2026

Uh oh!

dralley commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Apr 3, 2026

Uh oh!

weihanglo Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

dralley commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dralley Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

dralley Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weihanglo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dralley commented Apr 3, 2026 •

edited

Loading

dralley commented Apr 3, 2026 •

edited

Loading

dralley commented Apr 4, 2026 •

edited

Loading

dralley Apr 4, 2026 •

edited

Loading

weihanglo left a comment •

edited by rustbot

Loading