fix(core): use closest_msg to suggest similar member name for mistyped -p

src/cargo/core/workspace.rs

@@ -47,8 +47,8 @@ use crate::util::errors::{CargoResult, ManifestError};
 use crate::util::interning::InternedString;
 use crate::util::toml::{InheritableFields, read_manifest};
 use crate::util::{
-    Filesystem, GlobalContext, IntoUrl, context::CargoResolverConfig, context::ConfigRelativePath,
-    context::IncompatibleRustVersions,
+    Filesystem, GlobalContext, IntoUrl, closest_msg, context::CargoResolverConfig,
+    context::ConfigRelativePath, context::IncompatibleRustVersions,
 };
 
 use cargo_util::paths;
@@ -1890,7 +1890,19 @@ impl<'gctx> Workspace<'gctx> {
                 && !cli_features.all_features
                 && cli_features.uses_default_features)
             {
-                bail!("cannot specify features for packages outside of workspace");
+                let hint = specs
+                    .iter()
+                    .map(|spec| {
+                        closest_msg(
+                            spec.name(),
+                            self.members(),
+                            |m| m.name().as_str(),
+                            "workspace member",
+                        )
+                    })
+                    .find(|msg| !msg.is_empty())
+                    .unwrap_or_default();
+                bail!("cannot specify features for packages outside of workspace{hint}");
             }
             // Add all members from the workspace so we can ensure `-p nonmember`
             // is in the resolve graph.

tests/testsuite/package_features.rs

@@ -747,6 +747,8 @@ fn non_member() {
         .with_stderr_data(str![[r#"
 [ERROR] cannot specify features for packages outside of workspace
 
+[HELP] a workspace member with a similar name exists: `foo`
+
 "#]])
         .run();
 
@@ -755,6 +757,8 @@ fn non_member() {
         .with_stderr_data(str![[r#"
 [ERROR] cannot specify features for packages outside of workspace
 
+[HELP] a workspace member with a similar name exists: `foo`
+
 "#]])
         .run();
 
@@ -763,6 +767,8 @@ fn non_member() {
         .with_stderr_data(str![[r#"
 [ERROR] cannot specify features for packages outside of workspace
 
+[HELP] a workspace member with a similar name exists: `foo`
+
 "#]])
         .run();
 
@@ -779,6 +785,34 @@ fn non_member() {
         .run();
 }
 
+#[cargo_test]
+fn non_member_typo() {
+    // -p with a mistyped package name shows a helpful error hint
+    // about similarly named workspace members.
+    let p = project()
+        .file(
+            "Cargo.toml",
+            r#"
+            [workspace]
+            members = ["bar"]
+            resolver = "2"
+            "#,
+        )
+        .file("bar/Cargo.toml", &basic_manifest("bar", "1.0.0"))
+        .file("bar/src/lib.rs", "")
+        .build();
+
+    p.cargo("build -p barr --all-features")
+        .with_status(101)
+        .with_stderr_data(str![[r#"
+[ERROR] cannot specify features for packages outside of workspace
+
+[HELP] a workspace member with a similar name exists: `bar`
+
+"#]])
+        .run();
+}
+
 #[cargo_test]
 fn resolver1_member_features() {
     // --features member-name/feature-name with resolver="1"
@@ -962,6 +996,8 @@ fn non_member_feature() {
         .with_stderr_data(str![[r#"
 [ERROR] cannot specify features for packages outside of workspace
 
+[HELP] a workspace member with a similar name exists: `foo`
+
 "#]])
         .run();
 
@@ -983,20 +1019,26 @@ fn non_member_feature() {
         .with_stderr_data(str![[r#"
 [ERROR] cannot specify features for packages outside of workspace
 
+[HELP] a workspace member with a similar name exists: `foo`
+
 "#]])
         .run();
     p.cargo("check -p bar --features bar/jazz")
         .with_status(101)
         .with_stderr_data(str![[r#"
 [ERROR] cannot specify features for packages outside of workspace
 
+[HELP] a workspace member with a similar name exists: `foo`
+
 "#]])
         .run();
     p.cargo("check -p bar --features foo/bar")
         .with_status(101)
         .with_stderr_data(str![[r#"
 [ERROR] cannot specify features for packages outside of workspace
 
+[HELP] a workspace member with a similar name exists: `foo`
+
 "#]])
         .run();
 }