Skip to content

fix(lints): Ignore unused_crate_dependencies status #16877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weihanglo merged 2 commits into from
Apr 13, 2026
+337 −1
Merged

fix(lints): Ignore unused_crate_dependencies status #16877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd0f7e5
test(lints): Show interaction of unused_dependencies / used_crate_dep…
epage Apr 13, 2026
c4978dd
fix(lints): Ignore `unused_crate_dependencies` status
epage Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cargo/core/compiler/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ fn prepare_rustc(build_runner: &BuildRunner<'_, '_>, unit: &Unit) -> CargoResult
if build_runner.bcx.gctx.cli_unstable().cargo_lints {
// Added last to reduce the risk of RUSTFLAGS or `[lints]` from interfering with
// `unused_dependencies` tracking
base.arg("-Wunused_crate_dependencies");
base.arg("--force-warn=unused_crate_dependencies");
}

Ok(base)
Expand Down
336 changes: 336 additions & 0 deletions tests/testsuite/lints/unused_dependencies.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,3 +1378,339 @@ fn config_ignore() {
)
.run();
}

#[cargo_test]
fn allow_rustflags() {
// The most basic case where there is an unused dependency
Package::new("unused", "0.1.0").publish();
let p = project()
.file(
"Cargo.toml",
r#"
[package]
name = "foo"
version = "0.1.0"
authors = []
edition = "2018"

[dependencies]
unused = "0.1.0"

[lints.cargo]
unused_dependencies = "warn"
"#,
)
.file(
"src/main.rs",
r#"
fn main() {}
"#,
)
.build();

p.cargo("check -Zcargo-lints")
.env("RUSTFLAGS", "-Aunused_crate_dependencies")
.masquerade_as_nightly_cargo(&["cargo-lints"])
.with_stderr_data(str![[r#"
[UPDATING] `dummy-registry` index
[LOCKING] 1 package to latest compatible version
[DOWNLOADING] crates ...
[DOWNLOADED] unused v0.1.0 (registry `dummy-registry`)
[CHECKING] unused v0.1.0
[CHECKING] foo v0.1.0 ([ROOT]/foo)
[WARNING] unused dependency
--> Cargo.toml:9:13
|
9 | unused = "0.1.0"
| ^^^^^^^^^^^^^^^^
|
= [NOTE] `cargo::unused_dependencies` is set to `warn` by default
[HELP] remove the dependency
|
9 - unused = "0.1.0"
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

"#]])
.run();
}

#[cargo_test]
fn allow_attribute() {
// The most basic case where there is an unused dependency
Package::new("unused", "0.1.0").publish();
let p = project()
.file(
"Cargo.toml",
r#"
[package]
name = "foo"
version = "0.1.0"
authors = []
edition = "2018"

[dependencies]
unused = "0.1.0"

[lints.cargo]
unused_dependencies = "warn"
"#,
)
.file(
"src/main.rs",
r#"
#![allow(unused_crate_dependencies)]
fn main() {}
"#,
)
.build();

p.cargo("check -Zcargo-lints")
.masquerade_as_nightly_cargo(&["cargo-lints"])
.with_stderr_data(str![[r#"
[UPDATING] `dummy-registry` index
[LOCKING] 1 package to latest compatible version
[DOWNLOADING] crates ...
[DOWNLOADED] unused v0.1.0 (registry `dummy-registry`)
[CHECKING] unused v0.1.0
[CHECKING] foo v0.1.0 ([ROOT]/foo)
[WARNING] unused dependency
--> Cargo.toml:9:13
|
9 | unused = "0.1.0"
| ^^^^^^^^^^^^^^^^
|
= [NOTE] `cargo::unused_dependencies` is set to `warn` by default
[HELP] remove the dependency
|
9 - unused = "0.1.0"
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

"#]])
.run();
}

#[cargo_test]
fn deny_rustflags() {
// The most basic case where there is an unused dependency
Package::new("unused", "0.1.0").publish();
let p = project()
.file(
"Cargo.toml",
r#"
[package]
name = "foo"
version = "0.1.0"
authors = []
edition = "2018"

[dependencies]
unused = "0.1.0"

[lints.cargo]
unused_dependencies = "warn"
"#,
)
.file(
"src/main.rs",
r#"
fn main() {}
"#,
)
.build();

p.cargo("check -Zcargo-lints")
.env("RUSTFLAGS", "-Dunused_crate_dependencies")
.masquerade_as_nightly_cargo(&["cargo-lints"])
.with_stderr_data(str![[r#"
[UPDATING] `dummy-registry` index
[LOCKING] 1 package to latest compatible version
[DOWNLOADING] crates ...
[DOWNLOADED] unused v0.1.0 (registry `dummy-registry`)
[CHECKING] unused v0.1.0
[CHECKING] foo v0.1.0 ([ROOT]/foo)
[WARNING] unused dependency
--> Cargo.toml:9:13
|
9 | unused = "0.1.0"
| ^^^^^^^^^^^^^^^^
|
= [NOTE] `cargo::unused_dependencies` is set to `warn` by default
[HELP] remove the dependency
|
9 - unused = "0.1.0"
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

"#]])
.run();
}

#[cargo_test]
fn deny_attribute() {
// The most basic case where there is an unused dependency
Package::new("unused", "0.1.0").publish();
let p = project()
.file(
"Cargo.toml",
r#"
[package]
name = "foo"
version = "0.1.0"
authors = []
edition = "2018"

[dependencies]
unused = "0.1.0"

[lints.cargo]
unused_dependencies = "warn"
"#,
)
.file(
"src/main.rs",
r#"
#![deny(unused_crate_dependencies)]
fn main() {}
"#,
)
.build();

p.cargo("check -Zcargo-lints")
.masquerade_as_nightly_cargo(&["cargo-lints"])
.with_stderr_data(str![[r#"
[UPDATING] `dummy-registry` index
[LOCKING] 1 package to latest compatible version
[DOWNLOADING] crates ...
[DOWNLOADED] unused v0.1.0 (registry `dummy-registry`)
[CHECKING] unused v0.1.0
[CHECKING] foo v0.1.0 ([ROOT]/foo)
[WARNING] unused dependency
--> Cargo.toml:9:13
|
9 | unused = "0.1.0"
| ^^^^^^^^^^^^^^^^
|
= [NOTE] `cargo::unused_dependencies` is set to `warn` by default
[HELP] remove the dependency
|
9 - unused = "0.1.0"
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

"#]])
.run();
}

#[cargo_test]
fn forbid_rustflags() {
// The most basic case where there is an unused dependency
Package::new("unused", "0.1.0").publish();
let p = project()
.file(
"Cargo.toml",
r#"
[package]
name = "foo"
version = "0.1.0"
authors = []
edition = "2018"

[dependencies]
unused = "0.1.0"

[lints.cargo]
unused_dependencies = "warn"
"#,
)
.file(
"src/main.rs",
r#"
fn main() {}
"#,
)
.build();

p.cargo("check -Zcargo-lints")
.env("RUSTFLAGS", "-Funused_crate_dependencies")
.masquerade_as_nightly_cargo(&["cargo-lints"])
.with_stderr_data(str![[r#"
[UPDATING] `dummy-registry` index
[LOCKING] 1 package to latest compatible version
[DOWNLOADING] crates ...
[DOWNLOADED] unused v0.1.0 (registry `dummy-registry`)
[CHECKING] unused v0.1.0
[CHECKING] foo v0.1.0 ([ROOT]/foo)
[WARNING] unused dependency
--> Cargo.toml:9:13
|
9 | unused = "0.1.0"
| ^^^^^^^^^^^^^^^^
|
= [NOTE] `cargo::unused_dependencies` is set to `warn` by default
[HELP] remove the dependency
|
9 - unused = "0.1.0"
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

"#]])
.run();
}

#[cargo_test]
fn forbid_attribute() {
// The most basic case where there is an unused dependency
Package::new("unused", "0.1.0").publish();
let p = project()
.file(
"Cargo.toml",
r#"
[package]
name = "foo"
version = "0.1.0"
authors = []
edition = "2018"

[dependencies]
unused = "0.1.0"

[lints.cargo]
unused_dependencies = "warn"
"#,
)
.file(
"src/main.rs",
r#"
#![forbid(unused_crate_dependencies)]
fn main() {}
"#,
)
.build();

p.cargo("check -Zcargo-lints")
.masquerade_as_nightly_cargo(&["cargo-lints"])
.with_stderr_data(str![[r#"
[UPDATING] `dummy-registry` index
[LOCKING] 1 package to latest compatible version
[DOWNLOADING] crates ...
[DOWNLOADED] unused v0.1.0 (registry `dummy-registry`)
[CHECKING] unused v0.1.0
[CHECKING] foo v0.1.0 ([ROOT]/foo)
[WARNING] unused dependency
Copy link
Copy Markdown
Member

@weihanglo weihanglo Apr 13, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

Wait. So forbid attr loses to force-warn from CLI?

Copy link
Copy Markdown
Contributor Author

@epage epage Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was suprised

--> Cargo.toml:9:13
|
9 | unused = "0.1.0"
| ^^^^^^^^^^^^^^^^
|
= [NOTE] `cargo::unused_dependencies` is set to `warn` by default
[HELP] remove the dependency
|
9 - unused = "0.1.0"
|
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

"#]])
.run();
}