fix: Prefer defined lint levels over default by Muscraft · Pull Request #16879 · rust-lang/cargo

Muscraft · 2026-04-13T16:36:46Z

The current logic for selecting a level for a lint does not prioritize defined lint levels over the default one. This led to cases where the wrong level, or LintLevelReason, was chosen. To address this, I did two things. The first was renaming LintLevelReason to LintLevelSource, this was done to better align the name with how it will be used, as well as to align with how Rust names its similar struct. The second thing is to add LintLevelSource to the max_by_key in Lint::level, as a way to prioritize defined lint levels over the default one.

rustbot · 2026-04-13T16:36:52Z

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ehuss, @epage, @weihanglo
@ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
Random selection from ehuss, epage, weihanglo

epage · 2026-04-13T16:41:47Z

            (self.name, lint_level_priority),
            (self.primary_group.name, group_level_priority),
-            |(n, (l, _, p))| (l == &LintLevel::Forbid, *p, Reverse(*n)),
+            |(n, (l, s, p))| (l == &LintLevel::Forbid, *s, *p, Reverse(*n)),


View changes since the review

If we add any other LintLevelSources, this will suddenly break.

Maybe if we have a test for the bad package/default interaction beyond what source is being reported, it will catch people's attention and they can fix this in the moment?

Or should we do s == LintLevelSource::Default (or !=, whatever direction is needed)? That seems like that would better communicate intent and make this more resilient.

epage · 2026-04-13T16:41:57Z

+    }
+}
+
+impl Ord for LintLevelSource {


View changes since the review

Why is this manually implemented?

epage · 2026-04-13T16:42:25Z

  |             ^^^^^^^^^^^^^^^^
  |
-  = [NOTE] `cargo::unused_dependencies` is set to `warn` by default
+  = [NOTE] `cargo::unused_dependencies` is set to `warn` in `[lints]`


View changes since the review

would we be able to have a test that shows a behavior different rather than just a difference in the source in the note?

Muscraft · 2026-04-14T03:20:45Z

I think the failure was transient

rustbot · 2026-04-14T12:33:37Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Update cargo submodule 26 commits in eb94155a9a60943bd7b1cb04abec42f5d0de6ddc..3bf1388b8823ec4eab622340036593381d8871aa 2026-04-09 13:10:20 +0000 to 2026-04-17 23:27:26 +0000 - Add global HTTP timeout tracking to http_async (rust-lang/cargo#16903) - feat(config): Stabilize `resolver.lockfile-path` config (rust-lang/cargo#16694) - chore(deps): update msrv (1 version) to v1.95 (rust-lang/cargo#16897) - fix: rebuild rustdoc json for different versions of a same crate (rust-lang/cargo#16773) - Add effective_url to http_async (rust-lang/cargo#16899) - Make crate downloads process as a queue rather than a stack (rust-lang/cargo#16898) - fix: sparse registry fetch progress reporting (rust-lang/cargo#16900) - chore: bump to 0.98.0; update changelog (rust-lang/cargo#16892) - docs(semver-check): update diagnostics to Rust 1.95 (rust-lang/cargo#16895) - docs(ref): Better highlight 'package --list' for include/exclude (rust-lang/cargo#16891) - docs: `include` doesnt apply gitignore from repo (rust-lang/cargo#16890) - fix: Update `bash` and `zsh` Autocompletion Documents to add `-m` (rust-lang/cargo#16888) - Add `-m` shorthand for `--manifest-path` (rust-lang/cargo#16858) - Fix a typo (rust-lang/cargo#16885) - Always take a shared lock on `.cargo-lock` (rust-lang/cargo#16886) - fix(toml): Teach users how to pin edition (rust-lang/cargo#16851) - fix: Prefer defined lint levels over default (rust-lang/cargo#16879) - chore(deps): bump rand from 0.10.0 to 0.10.1 (rust-lang/cargo#16883) - fix(lints): Ignore unused_crate_dependencies status (rust-lang/cargo#16877) - Copy cargo clean target-dir validation tests to clean_new_layout.rs (rust-lang/cargo#16878) - cargo clean: Add target directory validation (rust-lang/cargo#16712) - Docs: "api" in the configuration should not include a trailing slash (rust-lang/cargo#16869) - fix(core): use `closest_msg` to suggest similar member name for mistyped `-p` (rust-lang/cargo#16844) - chore(ci): Pin GitHub Actions to commit SHAs (rust-lang/cargo#16868) - chore(ci): Update `actions/checkout` from v5 to v6 (rust-lang/cargo#16867) - Add test for cargo install with github fastpath (rust-lang/cargo#16866) r? ghost

Update cargo submodule 28 commits in eb94155a9a60943bd7b1cb04abec42f5d0de6ddc..7ecf0285ebb408d596e4a8ac76a0980d8edb7005 2026-04-09 13:10:20 +0000 to 2026-04-18 15:34:11 +0000 - fix: use `portable-atomic` for 64-bit atomics (rust-lang/cargo#16906) - fix: rename incorrectly documented target-spec-json to json-target-sp… (rust-lang/cargo#16905) - Add global HTTP timeout tracking to http_async (rust-lang/cargo#16903) - feat(config): Stabilize `resolver.lockfile-path` config (rust-lang/cargo#16694) - chore(deps): update msrv (1 version) to v1.95 (rust-lang/cargo#16897) - fix: rebuild rustdoc json for different versions of a same crate (rust-lang/cargo#16773) - Add effective_url to http_async (rust-lang/cargo#16899) - Make crate downloads process as a queue rather than a stack (rust-lang/cargo#16898) - fix: sparse registry fetch progress reporting (rust-lang/cargo#16900) - chore: bump to 0.98.0; update changelog (rust-lang/cargo#16892) - docs(semver-check): update diagnostics to Rust 1.95 (rust-lang/cargo#16895) - docs(ref): Better highlight 'package --list' for include/exclude (rust-lang/cargo#16891) - docs: `include` doesnt apply gitignore from repo (rust-lang/cargo#16890) - fix: Update `bash` and `zsh` Autocompletion Documents to add `-m` (rust-lang/cargo#16888) - Add `-m` shorthand for `--manifest-path` (rust-lang/cargo#16858) - Fix a typo (rust-lang/cargo#16885) - Always take a shared lock on `.cargo-lock` (rust-lang/cargo#16886) - fix(toml): Teach users how to pin edition (rust-lang/cargo#16851) - fix: Prefer defined lint levels over default (rust-lang/cargo#16879) - chore(deps): bump rand from 0.10.0 to 0.10.1 (rust-lang/cargo#16883) - fix(lints): Ignore unused_crate_dependencies status (rust-lang/cargo#16877) - Copy cargo clean target-dir validation tests to clean_new_layout.rs (rust-lang/cargo#16878) - cargo clean: Add target directory validation (rust-lang/cargo#16712) - Docs: "api" in the configuration should not include a trailing slash (rust-lang/cargo#16869) - fix(core): use `closest_msg` to suggest similar member name for mistyped `-p` (rust-lang/cargo#16844) - chore(ci): Pin GitHub Actions to commit SHAs (rust-lang/cargo#16868) - chore(ci): Update `actions/checkout` from v5 to v6 (rust-lang/cargo#16867) - Add test for cargo install with github fastpath (rust-lang/cargo#16866)

rustbot assigned epage Apr 13, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2026

epage reviewed Apr 13, 2026

View reviewed changes

Muscraft force-pushed the fix-prefer-defined-lints branch 4 times, most recently from 8ec2102 to 6d5b5dc Compare April 14, 2026 00:00

This comment has been minimized.

Sign in to view

epage approved these changes Apr 14, 2026

View reviewed changes

epage added this pull request to the merge queue Apr 14, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026

Muscraft added this pull request to the merge queue Apr 14, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026

Muscraft added 3 commits April 14, 2026 06:33

test(lints): Add tests for lint level priority selection

2d89b18

refactor(lints): Rename LintLevelReason to LintLevelSource

20dd0c8

fix: Prefer defined lint levels over default

4aec1e0

Muscraft force-pushed the fix-prefer-defined-lints branch from 6d5b5dc to 4aec1e0 Compare April 14, 2026 12:33

epage added this pull request to the merge queue Apr 14, 2026

Merged via the queue into rust-lang:master with commit 273393c Apr 14, 2026
29 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2026

Muscraft deleted the fix-prefer-defined-lints branch April 14, 2026 13:53

weihanglo mentioned this pull request Apr 18, 2026

Update cargo submodule rust-lang/rust#155470

Merged

rustbot added this to the 1.97.0 milestone Apr 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Prefer defined lint levels over default#16879

fix: Prefer defined lint levels over default#16879
epage merged 3 commits intorust-lang:masterfrom
Muscraft:fix-prefer-defined-lints

Muscraft commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

epage Apr 13, 2026 •

edited by rustbot

Loading

Uh oh!

epage Apr 13, 2026 •

edited by rustbot

Loading

Uh oh!

epage Apr 13, 2026 •

edited by rustbot

Loading

Uh oh!

This comment has been minimized.

Uh oh!

Muscraft commented Apr 14, 2026

Uh oh!

Uh oh!

rustbot commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Muscraft commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

epage Apr 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

epage Apr 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

epage Apr 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

Muscraft commented Apr 14, 2026

Uh oh!

Uh oh!

rustbot commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

epage Apr 13, 2026 •

edited by rustbot

Loading

epage Apr 13, 2026 •

edited by rustbot

Loading

epage Apr 13, 2026 •

edited by rustbot

Loading