refactor(compile): Log all ignored unused externs#16920
Merged
weihanglo merged 10 commits intorust-lang:masterfrom Apr 21, 2026
Merged
refactor(compile): Log all ignored unused externs#16920weihanglo merged 10 commits intorust-lang:masterfrom
weihanglo merged 10 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
approved these changes
Apr 21, 2026
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 25, 2026
Update cargo submodule 10 commits in 06ac0e7c05770a8c7bbf67bdd12fa1a1eefdc8ae..eb9b60f1f6604b5e022c56be31692c215b8ba11d 2026-04-21 15:33:56 +0000 to 2026-04-24 20:52:07 +0000 - chore: Remove unused deps (rust-lang/cargo#16938) - feat(compile): Stabilize `build.warnings` (rust-lang/cargo#16796) - cargo clean: do not error if explicitly specified target-dir does not exist (rust-lang/cargo#16934) - Revert "feat(lints): Add unused deps ignore list" (rust-lang/cargo#16937) - fix(compile): Ignore unused deps if also transitive (rust-lang/cargo#16935) - Update rustls (rust-lang/cargo#16932) - chore(deps): update rust crate openssl to v0.10.78 [security] (rust-lang/cargo#16931) - chore(build-rs): Ensure we lint the crate (rust-lang/cargo#16930) - Fix flaky test: proc_macro_in_artifact_dep (rust-lang/cargo#16922) - refactor(compile): Log all ignored unused externs (rust-lang/cargo#16920) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Shoring up the logging we do for unused dependency lints to help with debugging and profiling.
This could also be useful for users to get more insight on things we can't or won't show, like helping hunt down features to deactivate to reduce unused dependencies (e.g.
clionpulldown-cmark) or removing transitively unused dependencies.How to test and review this PR?
Running this on
cargoitself:Doesn't work too well for
--all-targetsbecause we don't support dev targets at the moment, so we don't track which externs came from dependencies vs dev-dependencies.Also, of note that I found while doing this that confused me at first is that we don't fingerprint
-Zcargo-lints, so users can have stale caches with no unused externs "reported" by rustc to cargo.