Auth with more usernames and improve errors #2407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
| } | ||
| UsernameAttempt::Local => { | ||
| username_attempt = UsernameAttempt::Git; | ||
| env::var("USER").ok() |
There was a problem hiding this comment.
On Windows, the local username is stored in the %USERNAME% environment variable. %USER% is not generally set.
alexcrichton
force-pushed
the
better-failed-auth-error
branch
from
5f9c3f1 to
c6149e3
Compare
|
@bors r+ |
|
📌 Commit c6149e3 has been approved by |
|
⌛ Testing commit c6149e3 with merge 627855a... |
|
💔 Test failed - cargo-linux-64 |
This commit is an attempt to improve the error message from failed authentication attempts as well as attempting more usernames. Right now we only attempt one username, but there are four different possible choices we could select (including $USER which we weren't previously trying). This commit tweaks a bunch of this logic and just in general refactors the with_authentication function. Closes rust-lang#2399
alexcrichton
force-pushed
the
better-failed-auth-error
branch
from
c6149e3 to
f66d716
Compare
bors
added a commit
that referenced
this pull request
Feb 25, 2016
This commit is an attempt to improve the error message from failed authentication attempts as well as attempting more usernames. Right now we only attempt one username, but there are four different possible choices we could select (including $USER which we weren't previously trying). This commit tweaks a bunch of this logic and just in general refactors the with_authentication function. Closes #2399
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an attempt to improve the error message from failed
authentication attempts as well as attempting more usernames. Right now we only
attempt one username, but there are four different possible choices we could
select (including $USER which we weren't previously trying).
This commit tweaks a bunch of this logic and just in general refactors the
with_authentication function.
Closes #2399