Skip to content

Add description to metadata output #3617#3633

Merged
bors merged 2 commits intorust-lang:masterfrom
shiver:3617
Feb 3, 2017
Merged

Add description to metadata output #3617#3633
bors merged 2 commits intorust-lang:masterfrom
shiver:3617

Conversation

@shiver
Copy link
Contributor

@shiver shiver commented Feb 2, 2017

Just took a quick stab at issue #3617.

Is my interpretation of the requirements correct, and if so, would you prefer new tests or are the current alterations sufficient.

Thanks!

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Looks great to me, thanks!

@bors
Copy link
Contributor

bors commented Feb 2, 2017

📌 Commit 7762949 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 3, 2017

⌛ Testing commit 7762949 with merge 12648f8...

bors added a commit that referenced this pull request Feb 3, 2017
Add description to metadata output #3617

Just took a quick stab at issue #3617.

Is my interpretation of the requirements correct, and if so, would you prefer new tests or are the current alterations sufficient.

Thanks!
@bors
Copy link
Contributor

bors commented Feb 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 12648f8 to master...

@bors bors merged commit 7762949 into rust-lang:master Feb 3, 2017
@shiver shiver deleted the 3617 branch May 22, 2017 22:42
@ehuss ehuss added this to the 1.17.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants