More intuitive CARGO_INCREMENTAL semantics#3689
Conversation
Previously, the mere presence of a CARGO_INCREMENTAL variable in the environment caused incremental compilation to happen. This has the very unintuitive effect that `CARGO_INCREMENTAL=0` and even `CARGO_INCREMENTAL=` mean incremental compilation is *on*. This change brings the semantics in line with how they are defined in the tests (cf. tests/build.rs:45), and in public-facing documentation (https://internals.rust-lang.org/t/incremental-compilation-beta/4721).
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ Thanks! |
|
📌 Commit 74cb863 has been approved by |
|
⌛ Testing commit 74cb863 with merge 020acef... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
…On Mon, Feb 13, 2017 at 9:42 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.1171>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3689 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95P619pVMc0jF8kss7BuLkopwxbObks5rcHnPgaJpZM4L-s5Y>
.
|
More intuitive CARGO_INCREMENTAL semantics Currently, the mere presence of a `CARGO_INCREMENTAL` variable in the environment causes incremental compilation to be enabled. This has the very counterintuitive effect that `CARGO_INCREMENTAL=0` and even `CARGO_INCREMENTAL=` mean incremental compilation is *on*. This PR brings the semantics in line with how they are defined in the tests (cf. [tests/build.rs:45](https://github.com/rust-lang/cargo/blob/master/tests/build.rs#L45)), and in [public-facing documentation](https://internals.rust-lang.org/t/incremental-compilation-beta/4721). See also [rust#39773](rust-lang/rust#39773) for an example of this causing confusion in the wild.
|
☀️ Test successful - status-appveyor, status-travis |
6 participants
Currently, the mere presence of a
CARGO_INCREMENTALvariable in the environment causes incremental compilation to be enabled. This has the very counterintuitive effect thatCARGO_INCREMENTAL=0and evenCARGO_INCREMENTAL=mean incremental compilation is on.This PR brings the semantics in line with how they are defined in the tests (cf. tests/build.rs:45), and in public-facing documentation.
See also rust#39773 for an example of this causing confusion in the wild.