Restore the generated tests module created by cargo new#3799
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 6, 2017
integer32llc:restore-generated-tests-module
Merged
Restore the generated tests module created by cargo new#3799bors merged 1 commit intorust-lang:masterfrom integer32llc:restore-generated-tests-module
cargo new#3799bors merged 1 commit intorust-lang:masterfrom
integer32llc:restore-generated-tests-module
Conversation
Appears to have been removed unintentionally in #3004.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
AHA I think i figured out what happened-- the original templating PR was created before the tests module was created! |
Member
|
@bors: r+ |
Contributor
|
📌 Commit de06b75 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Mar 6, 2017
…alexcrichton Restore the generated tests module created by `cargo new` Appears to have been removed unintentionally in #3004. Was just working on the book, ran `cargo new adder` with cargo-0.18.0-nightly (6f1b860 2017-02-11), and got this in `src/lib.rs`: ```rust #[test] fn it_works() { } ``` when I expected to get this: ```rust #[cfg(test)] mod tests { #[test] fn it_works() { } } ``` It looks like this was changed as part of #3004 ([removed](875a8ab#diff-149dd4362a3b0dc13b113762713119dfL477), [added](875a8ab#diff-149dd4362a3b0dc13b113762713119dfR678)), I'm assuming unintentionally? The regression has not yet hit the beta channel; `cargo-0.17.0-nightly (0bb8047 2017-02-06)` generates the src/lib.rs I expect.
Member
|
Heh, that's an amusing historical accident :) |
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appears to have been removed unintentionally in #3004.
Was just working on the book, ran
cargo new adderwith cargo-0.18.0-nightly (6f1b860 2017-02-11), and got this insrc/lib.rs:when I expected to get this:
It looks like this was changed as part of #3004 (removed, added), I'm assuming unintentionally?
The regression has not yet hit the beta channel;
cargo-0.17.0-nightly (0bb8047 2017-02-06)generates the src/lib.rs I expect.