Skip to content

Add an explanation of the labels #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2017
Merged

Add an explanation of the labels #4480

merged 2 commits into from
Sep 10, 2017

Conversation

carols10cents
Copy link
Member

As requested @matklad! ❤️ Are there any questions you have about the labels that remain unanswered?

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents
Copy link
Member Author

r? @matklad

@matklad
Copy link
Member

matklad commented Sep 10, 2017

Wow, that is much more thorough explanations than I had expected! Thanks a lot @carols10cents , I'be definitely learned more about our issues now ❣️

@bors r+

@bors
Copy link
Contributor

bors commented Sep 10, 2017

📌 Commit 0cfe635 has been approved by matklad

@bors
Copy link
Contributor

bors commented Sep 10, 2017

⌛ Testing commit 0cfe635 with merge 36ddeff...

bors added a commit that referenced this pull request Sep 10, 2017
Add an explanation of the labels

As requested @matklad! ❤️ Are there any questions you have about the labels that remain unanswered?
@bors
Copy link
Contributor

bors commented Sep 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 36ddeff to master...

@bors bors merged commit 0cfe635 into rust-lang:master Sep 10, 2017
@matklad
Copy link
Member

matklad commented Oct 2, 2017

@carols10cents what does E-mentor mean? I can think of at least to explanations:

  1. an issue with an actual live mentor, whom you can ping on IRC, ask questions, etc.
  2. an issue with some instructions on how to fix it (like, where's the relevant code, where are the tests, what should be changed).

Specifically, I've just created #4563 and I think it's mentor in the 2) sense, but not in the 1), so I don't know if I should apply the label :)

@carols10cents
Copy link
Member Author

@matklad to me, it means at least 2) and optionally 1) if 2) is insufficient :) I don't know if my interpretation is common though!

@carols10cents carols10cents deleted the explain-labels branch October 2, 2017 15:42
@ehuss ehuss added this to the 1.22.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants